Skip to content

Angular architect test rule escaping its runfiles but not the sandbox #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gregmagolan opened this issue Aug 3, 2022 · 2 comments
Open

Angular architect test rule escaping its runfiles but not the sandbox #347

gregmagolan opened this issue Aug 3, 2022 · 2 comments
Labels
bug Something isn't working need: investigation Investigation required to proceed further

Comments

@gregmagolan
Copy link
Member

This is causing test failures if srcs are not copied to bin

As seen here https://github.com/aspect-build/bazel-examples/blob/a76be559cd89a645308ff0f2e6a02a82c780010f/angular/defs.bzl#L133 and here https://github.com/aspect-build/bazel-examples/blob/a76be559cd89a645308ff0f2e6a02a82c780010f/angular/defs.bzl#L195
@gregmagolan gregmagolan added this to the 1.1 milestone Aug 3, 2022
@gregmagolan
Copy link
Member Author

We could add a copy_data_and_entry_to_bin attribute to js_binary as an escape hatch for this issue but we're better off understanding how it is escaping and fixing the root cause.

@gregmagolan gregmagolan changed the title Angular architect test rule escaping its runfiles not the sandbox Angular architect test rule escaping its runfiles but not the sandbox Aug 3, 2022
@gregmagolan gregmagolan added the bug Something isn't working label Aug 3, 2022
@gregmagolan
Copy link
Member Author

gregmagolan commented Aug 3, 2022 •
edited
Loading

Likely caused by #362. Need to confirm and then can close as a dup.

@gregmagolan gregmagolan mentioned this issue Aug 5, 2022
Open
@gregmagolan gregmagolan added need: investigation Investigation required to proceed further and removed prioritized labels Feb 4, 2023
@gregmagolan gregmagolan removed this from the Performance & Docs milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need: investigation Investigation required to proceed further
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgrindel @gregmagolan