Clippy cleanup

Author: asomers

benches/bench.rs

@@ -72,7 +72,7 @@ fn bench_threaded_read(bench: &mut Bencher) {
             tx.send(len).expect("sending failed");
         });
         let len = runtime.block_on(rx).expect("receiving failed");
-        assert_eq!(len as usize, FLEN);
+        assert_eq!(len, FLEN);
     });
 }
 
@@ -127,7 +127,7 @@ fn bench_threadpool_read(bench: &mut Bencher) {
         ptxclone.send(Some(opspec)).unwrap();
 
         let len = runtime.block_on(rx).expect("receiving failed");
-        assert_eq!(len as usize, FLEN);
+        assert_eq!(len, FLEN);
     });
     ptx.send(None).unwrap();
 }
@@ -152,6 +152,6 @@ fn bench_tokio_read(bench: &mut Bencher) {
             file.seek(SeekFrom::Start(0)).await.unwrap();
             file.read_exact(&mut rbuf[..]).await
         }).unwrap();
-        assert_eq!(len as usize, wbuf.len());
+        assert_eq!(len, wbuf.len());
     })
 }

src/file.rs

@@ -211,7 +211,7 @@ impl File {
     ///
     /// let file = fs::OpenOptions::new()
     ///     .read(true)
-    ///     .open(&path)
+    ///     .open(path)
     ///     .map(tokio_file::File::new)
     ///     .unwrap();
     /// let rt = runtime::Builder::new_current_thread()
@@ -277,7 +277,7 @@ impl File {
     ///
     /// let file = fs::OpenOptions::new()
     ///     .read(true)
-    ///     .open(&path)
+    ///     .open(path)
     ///     .map(tokio_file::File::new)
     ///     .unwrap();
     /// let rt = runtime::Builder::new_current_thread()
@@ -317,7 +317,7 @@ impl File {
     /// let file = fs::OpenOptions::new()
     ///     .write(true)
     ///     .create(true)
-    ///     .open(&path)
+    ///     .open(path)
     ///     .map(tokio_file::File::new)
     ///     .unwrap();
     /// let rt = runtime::Builder::new_current_thread()
@@ -367,7 +367,7 @@ impl File {
     /// assert_eq!(r, contents.len());
     /// drop(file);
     ///
-    /// let mut file = fs::File::open(&path).unwrap();
+    /// let mut file = fs::File::open(path).unwrap();
     /// assert_eq!(file.read_to_end(&mut rbuf).unwrap(), contents.len());
     /// assert_eq!(&contents[..], &rbuf[..]);
     /// ```
@@ -434,7 +434,7 @@ impl File {
     ///
     /// assert_eq!(r, 10);
     ///
-    /// let mut f = fs::File::open(&path).unwrap();
+    /// let mut f = fs::File::open(path).unwrap();
     /// let len = f.read_to_end(&mut rbuf).unwrap();
     /// assert_eq!(len, EXPECT.len());
     /// assert_eq!(rbuf, EXPECT);
@@ -475,7 +475,7 @@ mod t {
         let file = fs::OpenOptions::new()
             .write(true)
             .create(true)
-            .open(&path)
+            .open(path)
             .map(File::new)
             .unwrap();
         format!("{:?}", file);

tests/aio_write_eagain.rs

@@ -23,7 +23,7 @@ fn write_at_eagain() {
 
     let dir = t!(TempDir::new());
     let path = dir.path().join("write_at_eagain.0");
-    let file = t!(File::open(&path));
+    let file = t!(File::open(path));
 
     let wbuf = vec![0u8; 4096];
 

tests/file.rs

@@ -29,7 +29,7 @@ fn metadata() {
     let path = dir.path().join("metadata");
     let mut f = t!(fs::File::create(&path));
     f.write_all(&wbuf).expect("write failed");
-    let file = t!(File::open(&path));
+    let file = t!(File::open(path));
     let metadata = file.metadata().unwrap();
     assert_eq!(9000, metadata.len());
 }
@@ -40,7 +40,7 @@ fn len() {
     let path = dir.path().join("len");
     let f = t!(fs::File::create(&path));
     f.set_len(9000).unwrap();
-    let file = t!(File::open(&path));
+    let file = t!(File::open(path));
     assert_eq!(9000, file.len().unwrap());
 }
 
@@ -55,7 +55,7 @@ fn new_nocreat() {
         .read(true)
         .write(true)
         .create(false)
-        .open(&path)
+        .open(path)
         .map(tokio_file::File::new);
     assert!(r.is_err());
 }
@@ -251,7 +251,7 @@ mod dev {
     #[rstest]
     fn len(md: Option<Md>){
         if let Some(md) = md {
-            let file = t!(File::open(&md.0));
+            let file = t!(File::open(md.0.as_path()));
             let len = file.len().unwrap();
             assert_eq!(len, 1_048_576);
         } else {