Merge pull request devops-actions#148 from devops-actions/test

Fix issue with parsing yaml

Author: rajbos

Src/PowerShell/entrypoint.ps1

@@ -43,13 +43,13 @@ function main {
     }
 
     if ($null -eq $PAT -or "" -eq $PAT) {
-        Write-Error "No value given for input PAT: Use at least [GITHUB_TOKEN]"
-        throw
+        $PAT = $env:GITHUB_TOKEN
+        if ($null -eq $PAT -or "" -eq $PAT) {
+            Write-Error "No value given for input PAT: Use at least [GITHUB_TOKEN]"
+            throw
+        }
     }
 
-    echo $pwd
-    ls 
-
     # pull in the methods from load-actions:
     . $PSScriptRoot\load-used-actions.ps1 -orgName $organization -PAT $PAT
 
@@ -61,15 +61,15 @@ function main {
     }
 
     # write the file outside of the container so we can pick it up
-    Write-Host "Found [$($actions.Count)] actions"
+    Write-Host "Found [$($actions.Count)] unique actions"
     $jsonObject = ($actions | ConvertTo-Json -Depth 10 -Compress)    
 
     # store the json in a file and write the path to the output variable   
     $fileName = "used-actions.json"
     $filePath = "$($env:GITHUB_WORKSPACE)/$fileName"
 
     if ($null -ne $env:GITHUB_WORKSPACE -and "" -ne $env:GITHUB_WORKSPACE) {
-        Write-Host "Writing actions to file in workspace: [$($env:GITHUB_WORKSPACE)]"
+        Write-Host "Writing actions to file in workspace: [$($env:GITHUB_WORKSPACE)] to filePath [$filePath]"
         Set-Content -Value "$jsonObject" -Path "$filePath"
     }
     else {

Src/PowerShell/github-calls.ps1

@@ -57,18 +57,20 @@ function CallWebRequest {
         # convert the response json content
         $info = ($result.Content | ConvertFrom-Json)
 
-        Write-Debug "  Paging links: $($result.Headers["Link"])"
+        
+        $LinkHeader = $result.Headers["Link"]
+        Write-Debug "  Paging links: $($LinkHeader)"
         # Test for paging links and try to enumerate all pages
-        if ($null -ne $result.Headers["Link"]) {
+        if ($null -ne $LinkHeader) {
             #Write-Warning "Paging link detected:"
-            foreach ($page in $result.Headers["Link"].Split(", ")) {
+            foreach ($page in $LinkHeader.Split(",")) {
 
                 #Write-Host "Found page: [$page]"
                 #Write-Host "rel next found at: [$($page.Split(";")[1])" 
 
-                if ($page.Split("; ")[1] -eq 'rel="next"') {
+                if ($page.Split(";")[1].Trim() -eq 'rel="next"') {
                     #Write-Host "Next page is at [$page]"
-                    $almostUrl = $page.Split(";")[0]
+                    $almostUrl = $page.Split(";")[0].Trim()
                     #Write-Host "Almost: $almostUrl"
                     $linkUrl = $almostUrl.Substring(1, $almostUrl.Length - 2)
                     Write-Host "Handling pagination link with next page at: $linkUrl"
@@ -349,14 +351,21 @@ function GetRawFile {
     }
 
     try {
-        $result = $requestResult | Select-Object -Expand Content
+        $result = $requestResult.Content
+        $output = ""
+        # remove any empty lines or tabs in the result to prevent issues with parsing yaml
+        foreach ($line in $result.Split([Environment]::NewLine)) {
+            $trimmedLine = $line.Trim().Replace("`t", "").Replace(" ", "")
+            if ($trimmedLine.Length -gt 0) {
+                $output += $line + [Environment]::NewLine
+            }
+        }
+        return $output
     }
     catch {
         Write-Warning "Error converting file content from url [$($logUrl)]"
         Write-Warning "Error: [$_]"
         Write-Warning "Content: [$requestResult]"
         return ""
     }
-
-    return $result
 }

Src/PowerShell/load-used-actions.ps1

@@ -131,6 +131,7 @@ function GetAllUsedActionsFromRepo {
     foreach ($workflowFile in $workflowFiles) {
         try {
             if ($null -ne $workflowFile.download_url -and $workflowFile.download_url.Length -gt 0 -and $workflowFile.download_url.Split("?")[0].EndsWith(".yml")) { 
+                Write-Host "Loading workflow file: [$($workflowFile.name)]"
                 $workflow = GetRawFile -url $workflowFile.download_url -PAT $PAT -userName $userName
                 $actions = GetActionsFromWorkflow -workflow $workflow -workflowFileName $workflowFile.name -repo $repo
 
@@ -252,7 +253,7 @@ function LoadAllActionsFromConfiguration() {
 
         $summarizeActions = SummarizeActionsUsed -actions $actionsFound
 
-        Write-Host "Found [$($actionsFound.Count)] actions used in workflows with [$($summarizeActions.Count) unique actions]"
+        Write-Host "Found [$($actionsFound.Count)] actions used in [$($repos.Count)] repos by workflows with [$($summarizeActions.Count) unique actions]"
 
         # write the actions to disk
         $fileName = "summarized-actions.json"