Setup opts for test and add helper function for getting migrations

Author: ken-kost

test/migration_generator_test.exs

@@ -4,6 +4,8 @@ defmodule AshPostgres.MigrationGeneratorTest do
 
   import ExUnit.CaptureLog
 
+  alias AshPostgres.MigrationGenerator
+
   setup do
     current_shell = Mix.shell()
 
@@ -1252,13 +1254,17 @@ defmodule AshPostgres.MigrationGeneratorTest do
 
   describe "--dev option" do
     setup do
+      {snapshot_path, migration_path} = {"test_snapshots_path", "test_migration_path"}
+
       on_exit(fn ->
-        File.rm_rf!("test_snapshots_path")
-        File.rm_rf!("test_migration_path")
+        File.rm_rf!(snapshot_path)
+        File.rm_rf!(migration_path)
       end)
+
+      [opts: [snapshot_path: snapshot_path, migration_path: migration_path]]
     end
 
-    test "generates dev migration" do
+    test "generates dev migration", %{opts: opts} do
       defposts do
         attributes do
           uuid_primary_key(:id)
@@ -1268,32 +1274,14 @@ defmodule AshPostgres.MigrationGeneratorTest do
 
       defdomain([Post])
 
-      AshPostgres.MigrationGenerator.generate(Domain,
-        snapshot_path: "test_snapshots_path",
-        snapshots_only: false,
-        migration_path: "test_migration_path",
-        dev: true
-      )
-
-      assert [dev_file] =
-               Path.wildcard("test_migration_path/**/*_migrate_resources*.exs")
-               |> Enum.reject(&String.contains?(&1, "extensions"))
-
+      assert :ok == MigrationGenerator.generate(Domain, opts ++ [dev: true])
+      assert [dev_file] = get_migration_files(opts)
       assert String.contains?(dev_file, "_dev.exs")
-      contents = File.read!(dev_file)
-
-      AshPostgres.MigrationGenerator.generate(Domain,
-        snapshot_path: "test_snapshots_path",
-        migration_path: "test_migration_path"
-      )
-
-      assert [file] =
-               Path.wildcard("test_migration_path/**/*_migrate_resources*.exs")
-               |> Enum.reject(&String.contains?(&1, "extensions"))
-
+      assert {:ok, dev_file_read} = File.read(dev_file)
+      assert :ok == MigrationGenerator.generate(Domain, opts)
+      assert [file] = get_migration_files(opts)
+      assert dev_file_read == File.read!(file)
       refute String.contains?(file, "_dev.exs")
-
-      assert contents == File.read!(file)
     end
   end
 
@@ -2345,4 +2333,11 @@ defmodule AshPostgres.MigrationGeneratorTest do
                ~S[modify :post_id, references(:posts, column: :id, name: "comments_post_id_fkey", type: :uuid, prefix: "public")]
     end
   end
+
+  defp get_migration_files(opts) do
+    opts[:migration_path]
+    |> Path.join("**/*_migrate_resources*.exs")
+    |> Path.wildcard()
+    |> Enum.reject(&String.contains?(&1, "extensions"))
+  end
 end