fix: Don't remove double newlines from generated docs

Removing double newlines breaks formatting in e.g. the generated browser docs,
and breaks doctests, since they expect the example code sections to be separated
by the rest of the comments by double newlines.

Removing the calls to `trim_double_newlines` triggers a whole bunch of
formatting changes, but they should be harmless enough.

Fixes: #2433

Author: Munksgaard

lib/ash/code_interface.ex

@@ -457,15 +457,14 @@ defmodule Ash.CodeInterface do
         interface_options = Ash.Resource.Interface.interface_options(:calculate, nil)
 
         @doc """
-             #{calculation.description || "Calculates #{calculation.name} action on #{inspect(resource)}."}
+        #{calculation.description || "Calculates #{calculation.name} action on #{inspect(resource)}."}
 
-             #{Ash.CodeInterface.describe_calculation(resource, calculation, interface.args, interface.exclude_inputs, interface.custom_inputs)}
+        #{Ash.CodeInterface.describe_calculation(resource, calculation, interface.args, interface.exclude_inputs, interface.custom_inputs)}
 
-             ### Options
+        ### Options
 
-             #{interface_options.docs()}
-             """
-             |> Ash.CodeInterface.trim_double_newlines()
+        #{interface_options.docs()}
+        """
         @doc spark_opts: [
                {opts_location, interface_options.schema()}
              ]
@@ -523,15 +522,14 @@ defmodule Ash.CodeInterface do
         end
 
         @doc """
-             #{calculation.description || "Calculates #{calculation.name} action on #{inspect(resource)}."}
+        #{calculation.description || "Calculates #{calculation.name} action on #{inspect(resource)}."}
 
-             #{Ash.CodeInterface.describe_calculation(resource, calculation, interface.args, interface.exclude_inputs, interface.custom_inputs)}
+        #{Ash.CodeInterface.describe_calculation(resource, calculation, interface.args, interface.exclude_inputs, interface.custom_inputs)}
 
-             ### Options
+        ### Options
 
-             #{interface_options.docs()}
-             """
-             |> Ash.CodeInterface.trim_double_newlines()
+        #{interface_options.docs()}
+        """
         @doc spark_opts: [
                {opts_location, interface_options.schema()}
              ]
@@ -1643,15 +1641,14 @@ defmodule Ash.CodeInterface do
 
         @dialyzer {:nowarn_function, {interface.name, length(common_args) + 2}}
         @doc """
-             #{action.description || "Calls the #{action.name} action on #{inspect(resource)}."}
+        #{action.description || "Calls the #{action.name} action on #{inspect(resource)}."}
 
-             #{Ash.CodeInterface.describe_action(resource, action, interface.args, interface.exclude_inputs, interface.custom_inputs)}
+        #{Ash.CodeInterface.describe_action(resource, action, interface.args, interface.exclude_inputs, interface.custom_inputs)}
 
-             ## Options
+        ## Options
 
-             #{interface_options.docs()}
-             """
-             |> Ash.CodeInterface.trim_double_newlines()
+        #{interface_options.docs()}
+        """
 
         @doc spark_opts: [
                {first_opts_location, interface_options.schema()},
@@ -1673,17 +1670,16 @@ defmodule Ash.CodeInterface do
         # sobelow_skip ["DOS.BinToAtom"]
         @dialyzer {:nowarn_function, {:"#{interface.name}!", length(common_args) + 2}}
         @doc """
-             #{action.description || "Calls the #{action.name} action on #{inspect(resource)}."}
+        #{action.description || "Calls the #{action.name} action on #{inspect(resource)}."}
 
-             Raises any errors instead of returning them
+        Raises any errors instead of returning them
 
-             #{Ash.CodeInterface.describe_action(resource, action, interface.args, interface.exclude_inputs, interface.custom_inputs)}
+        #{Ash.CodeInterface.describe_action(resource, action, interface.args, interface.exclude_inputs, interface.custom_inputs)}
 
-             ## Options
+        ## Options
 
-             #{interface_options.docs()}
-             """
-             |> Ash.CodeInterface.trim_double_newlines()
+        #{interface_options.docs()}
+        """
 
         @doc spark_opts: [
                {first_opts_location, interface_options.schema()},
@@ -1722,13 +1718,12 @@ defmodule Ash.CodeInterface do
                  {first_opts_location + 1, interface_options.schema()}
                ]
           @doc """
-               Returns the #{subject_name} corresponding to the action.
+          Returns the #{subject_name} corresponding to the action.
 
-               ## Options
+          ## Options
 
-               #{Spark.Options.docs(subject_opts)}
-               """
-               |> Ash.CodeInterface.trim_double_newlines()
+          #{Spark.Options.docs(subject_opts)}
+          """
           @doc spark_opts: [
                  {first_opts_location, subject_opts},
                  {first_opts_location + 1, subject_opts}
@@ -1746,15 +1741,14 @@ defmodule Ash.CodeInterface do
 
         # sobelow_skip ["DOS.BinToAtom"]
         @doc """
-             Runs authorization checks for `#{inspect(resource)}.#{action.name}`
+        Runs authorization checks for `#{inspect(resource)}.#{action.name}`
 
-             See `Ash.can/3` for more information
+        See `Ash.can/3` for more information
 
-             ## Options
+        ## Options
 
-             #{Ash.Resource.Interface.CanOpts.docs()}
-             """
-             |> Ash.CodeInterface.trim_double_newlines()
+        #{Ash.Resource.Interface.CanOpts.docs()}
+        """
         @dialyzer {:nowarn_function, {:"can_#{interface.name}", length(common_args) + 3}}
         @doc spark_opts: [
                {first_opts_location + 1, Ash.Resource.Interface.CanOpts.schema()},
@@ -1834,15 +1828,14 @@ defmodule Ash.CodeInterface do
                {first_opts_location + 2, Ash.Resource.Interface.CanQuestionMarkOpts.schema()}
              ]
         @doc """
-             Runs authorization checks for `#{inspect(resource)}.#{action.name}`, returning a boolean.
+        Runs authorization checks for `#{inspect(resource)}.#{action.name}`, returning a boolean.
 
-             See `Ash.can?/3` for more information
+        See `Ash.can?/3` for more information
 
-             ## Options
+        ## Options
 
-             #{Ash.Resource.Interface.CanQuestionMarkOpts.docs()}
-             """
-             |> Ash.CodeInterface.trim_double_newlines()
+        #{Ash.Resource.Interface.CanQuestionMarkOpts.docs()}
+        """
         def unquote(:"can_#{interface.name}?")(
               actor,
               unquote_splicing(common_args),