fixed failing tests, updated to modern rspec syntax, remove an unused runtime dependency

Author: pcai

Gemfile

@@ -2,3 +2,6 @@ source "https://rubygems.org"
 
 gemspec
 
+group :development, :test do
+  gem 'byebug'
+end

omniauth-constantcontact2.gemspec

@@ -18,7 +18,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'omniauth', '~> 1.0'
   gem.add_dependency 'omniauth-oauth2', '~> 1.0'
   gem.add_dependency 'multi_json', '~> 1.0'
-  gem.add_dependency 'multi_xml'
 
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '~> 2.8'

spec/omniauth/strategies/constantcontact2_spec.rb

@@ -10,21 +10,21 @@
 
   describe '#client' do
     it 'should have the correct Constant Contact site' do
-      subject.client.site.should eq("https://oauth2.constantcontact.com")
+      expect(subject.client.site).to eq("https://oauth2.constantcontact.com")
     end
 
     it 'should have the correct authorization url' do
-      subject.client.options[:authorize_url].should eq("/oauth2/oauth/siteowner/authorize")
+      expect(subject.client.options[:authorize_url]).to eq("/oauth2/oauth/siteowner/authorize")
     end
 
     it 'should have the correct token url' do
-      subject.client.options[:token_url].should eq('/oauth2/oauth/token')
+      expect(subject.client.options[:token_url]).to eq('/oauth2/oauth/token')
     end
   end
 
   describe '#callback_path' do
     it 'should have the correct callback path' do
-      subject.callback_path.should eq('/auth/constantcontact/callback')
+      expect(subject.callback_path).to eq('/auth/constantcontact/callback')
     end
   end
 end

spec/spec_helper.rb

@@ -4,9 +4,12 @@
 SimpleCov.start
 require 'rspec'
 require 'rack/test'
+require 'byebug'
 require 'omniauth'
 require 'omniauth-constantcontact2'
 
+OmniAuth.config.test_mode = true
+
 Dir[File.expand_path('../support/**/*', __FILE__)].each { |f| require f }
 
 RSpec.configure do |config|

spec/support/shared_examples.rb

@@ -5,35 +5,35 @@
   describe '#client' do
     it 'should be initialized with symbolized client_options' do
       @options = { :client_options => { 'authorize_url' => 'https://example.com' } }
-      subject.client.options[:authorize_url].should == 'https://example.com'
+      expect(subject.client.options[:authorize_url]).to eq('https://example.com')
     end
   end
 
   describe '#authorize_params' do
     it 'should include any authorize params passed in the :authorize_params option' do
       @options = { :authorize_params => { :foo => 'bar', :baz => 'zip' } }
-      subject.authorize_params['foo'].should eq('bar')
-      subject.authorize_params['baz'].should eq('zip')
+      expect(subject.authorize_params['foo']).to eq('bar')
+      expect(subject.authorize_params['baz']).to eq('zip')
     end
 
     it 'should include top-level options that are marked as :authorize_options' do
       @options = { :authorize_options => [:scope, :foo], :scope => 'bar', :foo => 'baz' }
-      subject.authorize_params['scope'].should eq('bar')
-      subject.authorize_params['foo'].should eq('baz')
+      expect(subject.authorize_params['scope']).to eq('bar')
+      expect(subject.authorize_params['foo']).to eq('baz')
     end
   end
 
   describe '#token_params' do
     it 'should include any token params passed in the :token_params option' do
       @options = { :token_params => { :foo => 'bar', :baz => 'zip' } }
-      subject.token_params['foo'].should eq('bar')
-      subject.token_params['baz'].should eq('zip')
+      expect(subject.token_params['foo']).to eq('bar')
+      expect(subject.token_params['baz']).to eq('zip')
     end
 
     it 'should include top-level options that are marked as :token_options' do
       @options = { :token_options => [:scope, :foo], :scope => 'bar', :foo => 'baz' }
-      subject.token_params['scope'].should eq('bar')
-      subject.token_params['foo'].should eq('baz')
+      expect(subject.token_params['scope']).to eq('bar')
+      expect(subject.token_params['foo']).to eq('baz')
     end
   end
 end