Add new sniffs from Slevomat Coding standards 6.2

arxeiss · arxeiss · commit 8075258f36e4 · 2020-03-31T21:48:55.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,39 @@
 # Changelog
 
+## v0.5.x
+
+### v0.5.0
+
+> Requires Slevomat coding standards 6.2 or higher
+
+**Added rules:**
+- SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition
+- SlevomatCodingStandard.Classes.DisallowMultiPropertyDefinition
+- SlevomatCodingStandard.Functions.ArrowFunctionDeclaration
+- SlevomatCodingStandard.PHP.DisallowDirectMagicInvokeCall
+- SlevomatCodingStandard.Variables.DisallowSuperGlobalVariable
+- SlevomatCodingStandard.Whitespaces.DuplicateSpaces
+
+---
+
+## v0.4.0 - v0.4.1
+
+**Added rules:**
+
+- SlevomatCodingStandard.Arrays.MultiLineArrayEndBracketPlacement
+- SlevomatCodingStandard.Classes.ConstantSpacing
+- SlevomatCodingStandard.Classes.ParentCallSpacing
+- SlevomatCodingStandard.Classes.PropertySpacing
+- SlevomatCodingStandard.Classes.RequireMultiLineMethodSignature
+- SlevomatCodingStandard.Classes.RequireSingleLineMethodSignature
+- SlevomatCodingStandard.Functions.DisallowEmptyFunction
+- SlevomatCodingStandard.Operators.NegationOperatorSpacing
+
+**Removed rule:**
+- Squiz.WhiteSpace.MemberVarSpacing
+
+---
+
 ## v0.3.x
 
 ### v0.3.0
diff --git a/README.md b/README.md
@@ -130,11 +130,13 @@ There is no really good documentation for sniffs. I wrote one sentence explanati
  - PSR2.Namespaces.NamespaceDeclaration
  - PSR2.Namespaces.UseDeclaration
 
-### SlevomatCodingStandard (44 sniffs)
- - SlevomatCodingStandard.Arrays.TrailingArrayComma
+### SlevomatCodingStandard (62 sniffs)
  - SlevomatCodingStandard.Arrays.MultiLineArrayEndBracketPlacement
+ - SlevomatCodingStandard.Arrays.TrailingArrayComma
  - SlevomatCodingStandard.Classes.ConstantSpacing
  - SlevomatCodingStandard.Classes.DisallowLateStaticBindingForConstants
+ - SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition
+ - SlevomatCodingStandard.Classes.DisallowMultiPropertyDefinition
  - SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces
  - SlevomatCodingStandard.Classes.ModernClassNameReference
  - SlevomatCodingStandard.Classes.ParentCallSpacing
@@ -146,12 +148,14 @@ There is no really good documentation for sniffs. I wrote one sentence explanati
  - SlevomatCodingStandard.Commenting.EmptyComment
  - SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration
  - SlevomatCodingStandard.Commenting.RequireOneLinePropertyDocComment
+ - SlevomatCodingStandard.Commenting.UselessFunctionDocComment
  - SlevomatCodingStandard.ControlStructures.EarlyExit
  - SlevomatCodingStandard.ControlStructures.JumpStatementsSpacing
  - SlevomatCodingStandard.ControlStructures.LanguageConstructWithParentheses
  - SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator
  - SlevomatCodingStandard.Exceptions.DeadCatch
  - SlevomatCodingStandard.Exceptions.ReferenceThrowableOnly
+ - SlevomatCodingStandard.Functions.ArrowFunctionDeclaration
  - SlevomatCodingStandard.Functions.DisallowEmptyFunction
  - SlevomatCodingStandard.Functions.StaticClosure
  - SlevomatCodingStandard.Functions.TrailingCommaInCall
@@ -170,11 +174,25 @@ There is no really good documentation for sniffs. I wrote one sentence explanati
  - SlevomatCodingStandard.Namespaces.UseSpacing
  - SlevomatCodingStandard.Namespaces.UselessAlias
  - SlevomatCodingStandard.Numbers.DisallowNumericLiteralSeparator
+ - SlevomatCodingStandard.Operators.DisallowEqualOperators
+ - SlevomatCodingStandard.Operators.DisallowIncrementAndDecrementOperators
  - SlevomatCodingStandard.Operators.NegationOperatorSpacing
+ - SlevomatCodingStandard.PHP.DisallowDirectMagicInvokeCall
  - SlevomatCodingStandard.PHP.OptimizedFunctionsWithoutUnpacking
  - SlevomatCodingStandard.PHP.ShortList
  - SlevomatCodingStandard.PHP.TypeCast
+ - SlevomatCodingStandard.TypeHints.DeclareStrictTypes
+ - SlevomatCodingStandard.TypeHints.LongTypeHints
+ - SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue
+ - SlevomatCodingStandard.TypeHints.ParameterTypeHint
+ - SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing
+ - SlevomatCodingStandard.TypeHints.PropertyTypeHint
+ - SlevomatCodingStandard.TypeHints.PropertyTypeHintSpacing
+ - SlevomatCodingStandard.TypeHints.ReturnTypeHint
+ - SlevomatCodingStandard.TypeHints.UselessConstantTypeHint
+ - SlevomatCodingStandard.Variables.DisallowSuperGlobalVariable
  - SlevomatCodingStandard.Variables.UnusedVariable
+ - SlevomatCodingStandard.Whitespaces.DuplicateSpaces
 
 ### Squiz (34 sniffs)
  - Squiz.Arrays.ArrayBracketSpacing
diff --git a/Rules/Parts/phpcs-psr.xml b/Rules/Parts/phpcs-psr.xml
@@ -5,6 +5,7 @@
         <exclude name="Generic.WhiteSpace.DisallowTabIndent"/> <!-- Is handled later, someone want tabs indentation -->
         <exclude name="PSR2.ControlStructures.ControlStructureSpacing.SpacingAfterOpenBrace"/><!-- we want to put first expression of multiline condition on next line -->
         <exclude name="PSR2.Classes.ClassDeclaration.CloseBraceAfterBody"/> <!-- Handled by Slevomat rules -->
+        <exclude name="PSR2.Classes.PropertyDeclaration.Multiple"/> <!-- Handled by Slevomat rules -->
     </rule>
     <rule ref="PSR12">
         <exclude name="PSR12.Traits.UseDeclaration.MultipleImport"/> <!-- Single use can import multiple traits -->
diff --git a/Rules/Parts/phpcs-slevomat.xml b/Rules/Parts/phpcs-slevomat.xml
@@ -11,6 +11,8 @@
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.Classes.DisallowLateStaticBindingForConstants"/> <!-- Disable static:: for constants -->
+    <rule ref="SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition"/> <!-- Cannot be more constants on the same row -->
+    <rule ref="SlevomatCodingStandard.Classes.DisallowMultiPropertyDefinition"/> <!-- Cannot be more properties on the same row -->
     <rule ref="SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces"> <!-- No empty lines in the start and end of class -->
         <properties>
             <property name="linesCountAfterOpeningBrace" value="0"/>
@@ -45,6 +47,7 @@
     <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator"/> <!-- Use null coalesce ?? instead of ternary when possible -->
     <rule ref="SlevomatCodingStandard.Exceptions.DeadCatch"/> <!-- Check unreachable catch blocks -->
     <rule ref="SlevomatCodingStandard.Exceptions.ReferenceThrowableOnly"/> <!-- \Exception should be \Throwable -->
+    <rule ref="SlevomatCodingStandard.Functions.ArrowFunctionDeclaration"/> <!-- Spacing around PHP 7.4 arrow functions -->
     <rule ref="SlevomatCodingStandard.Functions.DisallowEmptyFunction"/> <!-- Empty function must have a comment why is empty -->
     <rule ref="SlevomatCodingStandard.Functions.StaticClosure"/> <!-- Use static closure if not using $this -->
     <rule ref="SlevomatCodingStandard.Functions.TrailingCommaInCall"/> <!-- PHP 7.3+ add trailing comma in multiline function call -->
@@ -76,8 +79,16 @@
     <rule ref="SlevomatCodingStandard.Numbers.DisallowNumericLiteralSeparator"/> <!-- Disable write number with _ between thousands etc -->
     <rule ref="SlevomatCodingStandard.Namespaces.UseSpacing"/> <!-- Empty lines around use statements -->
     <rule ref="SlevomatCodingStandard.Operators.NegationOperatorSpacing"/> <!-- No spaces after - (minus) when is meant as negative number -->
+    <rule ref="SlevomatCodingStandard.PHP.DisallowDirectMagicInvokeCall"/> <!-- Cannot call directly __invoke method -->
     <rule ref="SlevomatCodingStandard.PHP.OptimizedFunctionsWithoutUnpacking"/> <!-- In listed function ... must not be used -->
     <rule ref="SlevomatCodingStandard.PHP.ShortList"/> <!-- Disable list() use [] -->
     <rule ref="SlevomatCodingStandard.PHP.TypeCast"/> <!-- Enforces using shorthand cast operators integer -> int -->
+    <rule ref="SlevomatCodingStandard.Variables.DisallowSuperGlobalVariable"/> <!-- Global variables are prohibited -->
     <rule ref="SlevomatCodingStandard.Variables.UnusedVariable"/> <!-- Try to detect unused variables -->
+    <rule ref="SlevomatCodingStandard.Whitespaces.DuplicateSpaces"> <!-- Detect duplicate spaces except assignment and comments -->
+        <properties>
+            <property name="ignoreSpacesBeforeAssignment" value="true"/>
+            <property name="ignoreSpacesInAnnotation" value="true"/>
+        </properties>
+    </rule>
 </ruleset>
diff --git a/composer.json b/composer.json
@@ -12,6 +12,6 @@
     ],
     "require": {
     	"php": "^7.1",
-        "slevomat/coding-standard": "^6.1.1"
+        "slevomat/coding-standard": "^6.2.0"
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,6 @@`
`12`	`12`	`],`
`13`	`13`	`"require": {`
`14`	`14`	`"php": "^7.1",`
`15`		`- "slevomat/coding-standard": "^6.1.1"`
	`15`	`+ "slevomat/coding-standard": "^6.2.0"`
`16`	`16`	`}`
`17`	`17`	`}`