Add more rules

Author: arxeiss

CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## v0.9.x
+
+### v0.9.0
+
+**Added rules:**
+ - Generic.CodeAnalysis.JumbledIncrementer
+ - Generic.Functions.CallTimePassByReference
+ - Generic.PHP.BacktickOperator
+ - Generic.PHP.DiscourageGoto
+ - Generic.VersionControl.GitMergeConflict
+ - SlevomatCodingStandard.Classes.ClassConstantVisibility
+ - SlevomatCodingStandard.Functions.UselessParameterDefaultValue
+
+**Added strict rules:**
+ - Generic.CodeAnalysis.ForLoopWithTestFunctionCall - *By default produce only a Warning*
+
 ## v0.8.x
 
 ### v0.8.0

Rules/Parts/phpcs-generic.xml

@@ -21,14 +21,18 @@
         <exclude name="Generic.CodeAnalysis.EmptyStatement.DetectedCatch"/><!-- empty catch statements are allowed - Squiz check comment inside empty catch -->
     </rule>
     <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop"/> <!-- for without iterators can be while -->
+    <rule ref="Generic.CodeAnalysis.JumbledIncrementer"/> <!-- Accidentally incrementing iterator of outer loop inside inner loop -->
     <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/> <!-- Disable if(true) etc... -->
     <rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier"/> <!-- When final is for class and for method again -->
     <rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/> <!-- When method only calls parent, nothing more -->
     <rule ref="Generic.Files.InlineHTML"/> <!-- Disables Inline HTML inside file -->
+    <rule ref="Generic.Functions.CallTimePassByReference"/> <!-- Cannot use reference in function call -->
     <rule ref="Generic.Formatting.NoSpaceAfterCast"/> <!-- Disable space after cast, ie (int) $var -->
     <rule ref="Generic.NamingConventions.ConstructorName"/> <!-- Check of usage old constructor naming -->
+    <rule ref="Generic.PHP.BacktickOperator"/> <!-- Backtick is used to call shell -->
     <rule ref="Generic.PHP.CharacterBeforePHPOpeningTag"/> <!-- No chars before PHP opening tag  -->
     <rule ref="Generic.PHP.DeprecatedFunctions"/> <!-- Disable deprecated function -->
+    <rule ref="Generic.PHP.DiscourageGoto"/> <!-- goto cannot be used -->
     <rule ref="Generic.PHP.ForbiddenFunctions"> <!-- Ban listed functions -->
         <properties>
             <property name="forbiddenFunctions" type="array">
@@ -45,6 +49,7 @@
             <property name="allowMultiline" value="true"/> <!-- But splitting into multiple lines is allowed -->
         </properties>
     </rule>
+    <rule ref="Generic.VersionControl.GitMergeConflict"/> <!-- Detect git merge conflict artifacts -->
     <rule ref="Generic.WhiteSpace.ArbitraryParenthesesSpacing"> <!-- No extra spaces inside parentheses -->
         <properties>
             <property name="ignoreNewlines" value="true"/>

Rules/Parts/phpcs-slevomat.xml

@@ -5,6 +5,7 @@
 
     <rule ref="SlevomatCodingStandard.Arrays.TrailingArrayComma"/> <!-- Multiline array must have trailing comma -->
     <rule ref="SlevomatCodingStandard.Arrays.MultiLineArrayEndBracketPlacement"/>
+    <rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility" /> <!-- Constants must have visibility operator -->
     <rule ref="SlevomatCodingStandard.Classes.ConstantSpacing"> <!-- Proper spacing for constants with and without docblock -->
         <properties>
             <property name="maxLinesCountBeforeWithoutComment" value="0"/>
@@ -61,10 +62,11 @@
     <rule ref="SlevomatCodingStandard.Functions.ArrowFunctionDeclaration"/> <!-- Spacing around PHP 7.4 arrow functions -->
     <rule ref="SlevomatCodingStandard.Functions.DisallowEmptyFunction"/> <!-- Empty function must have a comment why is empty -->
     <rule ref="SlevomatCodingStandard.Functions.RequireMultiLineCall"/> <!-- Can fix when max line length of function call is exceeded -->
-    <rule ref="SlevomatCodingStandard.Functions.StaticClosure"/> <!-- Use static closure if not using $this -->
     <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInCall"/> <!-- PHP 7.3+ add trailing comma in multiline function call -->
     <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration"/> <!-- PHP 8.0+ add trailing comma in multiline function declaration -->
+    <rule ref="SlevomatCodingStandard.Functions.StaticClosure"/> <!-- Use static closure if not using $this -->
     <rule ref="SlevomatCodingStandard.Functions.UnusedInheritedVariablePassedToClosure"/> <!-- Check unused variable in use() for closure -->
+    <rule ref="SlevomatCodingStandard.Functions.UselessParameterDefaultValue" />
     <rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses"/> <!-- Namespace use sort alphabetically -->
     <rule ref="SlevomatCodingStandard.Namespaces.DisallowGroupUse"/> <!-- Group use namespaces declaration is disallowed -->
     <rule ref="SlevomatCodingStandard.Namespaces.FullyQualifiedExceptions"/> <!-- Exception is always fully qualified class names -->

Rules/phpcs-strict.xml

@@ -4,6 +4,7 @@
     <config name="installed_paths" value="../../slevomat/coding-standard"/>
 
     <!-- Generic -->
+    <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall"/>
     <rule ref="Generic.Formatting.SpaceAfterNot"> <!-- Checks there is 0 lines after ! operator -->
         <properties>
             <property name="spacing" value="0"/>

SniffsList.md

@@ -1,12 +1,14 @@
 # All used sniffs
 
-### Generic (37 sniffs)
+### Generic (43 sniffs)
  - Generic.Arrays.ArrayIndent
  - Generic.Arrays.DisallowLongArraySyntax
  - Generic.Classes.DuplicateClassName
  - Generic.CodeAnalysis.AssignmentInCondition
  - Generic.CodeAnalysis.EmptyStatement
  - Generic.CodeAnalysis.ForLoopShouldBeWhileLoop
+ - Generic.CodeAnalysis.ForLoopWithTestFunctionCall
+ - Generic.CodeAnalysis.JumbledIncrementer
  - Generic.CodeAnalysis.UnconditionalIfStatement
  - Generic.CodeAnalysis.UnnecessaryFinalModifier
  - Generic.CodeAnalysis.UselessOverridingMethod
@@ -19,19 +21,23 @@
  - Generic.Formatting.DisallowMultipleStatements
  - Generic.Formatting.NoSpaceAfterCast
  - Generic.Formatting.SpaceAfterNot
+ - Generic.Functions.CallTimePassByReference
  - Generic.Functions.FunctionCallArgumentSpacing
  - Generic.NamingConventions.ConstructorName
  - Generic.NamingConventions.UpperCaseConstantName
+ - Generic.PHP.BacktickOperator
  - Generic.PHP.CharacterBeforePHPOpeningTag
  - Generic.PHP.DeprecatedFunctions
  - Generic.PHP.DisallowAlternativePHPTags
  - Generic.PHP.DisallowShortOpenTag
+ - Generic.PHP.DiscourageGoto
  - Generic.PHP.ForbiddenFunctions
  - Generic.PHP.LowerCaseConstant
  - Generic.PHP.LowerCaseKeyword
  - Generic.PHP.LowerCaseType
  - Generic.PHP.NoSilencedErrors
  - Generic.Strings.UnnecessaryStringConcat
+ - Generic.VersionControl.GitMergeConflict
  - Generic.WhiteSpace.ArbitraryParenthesesSpacing
  - Generic.WhiteSpace.DisallowSpaceIndent - *Depends on selected indentation configuration*
  - Generic.WhiteSpace.DisallowTabIndent - *Depends on selected indentation configuration*
@@ -89,6 +95,7 @@
  - SlevomatCodingStandard.Arrays.MultiLineArrayEndBracketPlacement
  - SlevomatCodingStandard.Arrays.SingleLineArrayWhitespace
  - SlevomatCodingStandard.Arrays.TrailingArrayComma
+ - SlevomatCodingStandard.Classes.ClassConstantVisibility
  - SlevomatCodingStandard.Classes.ConstantSpacing
  - SlevomatCodingStandard.Classes.DisallowLateStaticBindingForConstants
  - SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition
@@ -132,6 +139,7 @@
  - SlevomatCodingStandard.Functions.StaticClosure
  - SlevomatCodingStandard.Functions.RequireTrailingCommaInCall
  - SlevomatCodingStandard.Functions.UnusedInheritedVariablePassedToClosure
+ - SlevomatCodingStandard.Functions.UselessParameterDefaultValue
  - SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses
  - SlevomatCodingStandard.Namespaces.DisallowGroupUse
  - SlevomatCodingStandard.Namespaces.FullyQualifiedExceptions