Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to look how we can add more cities #25

Open
arvindvyas opened this issue Oct 25, 2015 · 6 comments
Open

Need to look how we can add more cities #25

arvindvyas opened this issue Oct 25, 2015 · 6 comments

Comments

@arvindvyas
Copy link
Owner

Need to look city-state gem , for update cities , in our gem , currently I have seen there are lots of cities are not available , need to check how we can update that data

@kxu1988
Copy link

kxu1988 commented Apr 30, 2016

gem countries(https://github.com/hexorx/countries) maybe a better choice, this gem maintains well.

"All sorts of useful information about every country packaged as convenient little country objects. It includes data from ISO 3166 (countries and states/subdivisions ), ISO 4217 (currency), and E.164 (phone numbers)."

@arvindvyas
Copy link
Owner Author

@kxu1988 thanks for suggestion but they don't provide cities , currently we are looking to add more cities .

@matthewvb
Copy link

matthewvb commented May 10, 2016

I'm also interested in modifying this a bit. Looks like the source of cities / states is linked to https://github.com/loureirorg/city-state. Any plans to merge the db from city-state natively in the app?

@arvindvyas you could submit a pull request to https://github.com/loureirorg/city-state with the new cities you'd like listed.

Edit: found a bit more info on the db source and updated the comment. Added note about pull request.

@arvindvyas
Copy link
Owner Author

@matthewvb no plan yet to merge the cities to natively in the app.

I am looking to provide update city method from this gem.

@wonderphil
Copy link

Hi guys,

I just started using your gem, which by the way is awesome, so thanks. When I first started using it the city list was for the UK at least pretty much nothing. But looking at the city-state gem, I have just added a function that runs CS.update . This pretty much gave me all the city but only issue I found is it didn't remove any old mapping.

So not sure if this is a question for you or they guys who wrote city-state. any thoughts?

Thanks

Phil

@arvindvyas
Copy link
Owner Author

@wonderphil we are looking to move such functionality into our gem once that will be done we can commit anything on this, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants