Skip to content

sync() function default value #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sakchal opened this issue Mar 25, 2024 · 1 comment
Closed

sync() function default value #40

sakchal opened this issue Mar 25, 2024 · 1 comment

Comments

@sakchal
Copy link
Contributor

sakchal commented Mar 25, 2024

The sync function is supposed to take a default device_id value of -1 according to the docs, but I'm forced to pass in an argument when calling the function. I made a PR for a potential fix.

def sync(device_id: int, /) -> None:
    """
    Blocks until all operations on device are finished.

    Parameters
    ----------
    device_id: int
        Id of the target device.
    """
    call_from_clib(sync.__name__, `device_id)
@syurkevi
Copy link
Contributor

Addressed in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants