From 3364e9b5035a68df4f737b0e3269f40d02804811 Mon Sep 17 00:00:00 2001 From: Mayel de Borniol <115318+mayel@users.noreply.github.com> Date: Tue, 24 Jan 2023 09:32:59 +1300 Subject: [PATCH] Update Telemetry examples for LiveView socket connected? (#5220) --- guides/telemetry.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/guides/telemetry.md b/guides/telemetry.md index fe6f82776c..f9e0499cd4 100644 --- a/guides/telemetry.md +++ b/guides/telemetry.md @@ -418,7 +418,7 @@ the previous example. defp live_view_metric_tag_values(metadata) do metadata |> Map.put(:view, metadata.socket.view) - |> Map.put(:connected?, metadata.socket.connected?) + |> Map.put(:connected?, Phoenix.LiveView.connected?(metadata.socket)) end ``` @@ -435,11 +435,11 @@ convert the `connected?` boolean into human readable text. defp live_view_metric_tag_values(metadata) do metadata |> Map.put(:view, inspect(metadata.socket.view)) - |> Map.put(:connected?, get_connection_status(metadata.socket)) + |> Map.put(:connected?, get_connection_status(Phoenix.LiveView.connected?(metadata.socket))) end -defp get_connection_status(%{connected?: true}), do: "Connected" -defp get_connection_status(%{connected?: false}), do: "Disconnected" +defp get_connection_status(true), do: "Connected" +defp get_connection_status(false), do: "Disconnected" ``` Now the value label will be rendered like `"Phoenix.LiveDashboard.MetricsLive