Skip to content

Commit 1dd43c8

Browse files
committed
Remove unecessary comments, improve other relevant ones
1 parent 1026720 commit 1dd43c8

File tree

5 files changed

+8
-21
lines changed

5 files changed

+8
-21
lines changed

guides/directory_structure.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,10 @@ The `lib/hello/application.ex` file defines an Elixir application named `Hello.A
4949

5050
```elixir
5151
children = [
52-
# Start the Telemetry supervisor
5352
HelloWeb.Telemetry,
54-
# Start the Ecto repository
5553
Hello.Repo,
56-
# Start the PubSub system
5754
{Phoenix.PubSub, name: Hello.PubSub},
58-
# Start the Endpoint (http/https)
5955
HelloWeb.Endpoint
60-
# Start a worker by calling: Hello.Worker.start_link(arg)
61-
# {Hello.Worker, arg}
6256
]
6357
```
6458

guides/mix_tasks.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ We certainly should follow the instructions and add our new repo to our supervis
599599
```elixir
600600
. . .
601601
children = [
602-
# Start the Ecto repository
603602
Hello.Repo,
604603
# Our custom repo
605604
OurCustom.Repo,

installer/templates/phx_single/lib/app_name/application.ex

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,15 @@ defmodule <%= @app_module %>.Application do
88
@impl true
99
def start(_type, _args) do
1010
children = [
11-
# Start the Telemetry supervisor
1211
<%= @web_namespace %>.Telemetry,<%= if @ecto do %>
13-
# Start the Ecto repository
1412
<%= @app_module %>.Repo,<% end %>
15-
# Start the PubSub system
1613
{Phoenix.PubSub, name: <%= @app_module %>.PubSub},<%= if @mailer do %>
17-
# Start Finch
14+
# Start the Finch HTTP client for sending emails
1815
{Finch, name: <%= @app_module %>.Finch},<% end %>
19-
# Start the Endpoint (http/https)
20-
<%= @endpoint_module %>
2116
# Start a worker by calling: <%= @app_module %>.Worker.start_link(arg)
22-
# {<%= @app_module %>.Worker, arg}
17+
# {<%= @app_module %>.Worker, arg},
18+
# Start to serve requests, typically the last entry
19+
<%= @endpoint_module %>
2320
]
2421

2522
# See https://hexdocs.pm/elixir/Supervisor.html

installer/templates/phx_umbrella/apps/app_name/lib/app_name/application.ex

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@ defmodule <%= @app_module %>.Application do
88
@impl true
99
def start(_type, _args) do
1010
children = [<%= if @ecto do %>
11-
# Start the Ecto repository
1211
<%= @app_module %>.Repo,<% end %>
13-
# Start the PubSub system
1412
{Phoenix.PubSub, name: <%= @app_module %>.PubSub}<%= if @mailer do %>,
15-
# Start Finch
13+
# Start the Finch HTTP client for sending emails
1614
{Finch, name: <%= @app_module %>.Finch}<% end %>
1715
# Start a worker by calling: <%= @app_module %>.Worker.start_link(arg)
1816
# {<%= @app_module %>.Worker, arg}

installer/templates/phx_umbrella/apps/app_name_web/lib/app_name/application.ex

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ defmodule <%= @web_namespace %>.Application do
88
@impl true
99
def start(_type, _args) do
1010
children = [
11-
# Start the Telemetry supervisor
1211
<%= @web_namespace %>.Telemetry,
13-
# Start the Endpoint (http/https)
14-
<%= @endpoint_module %>
1512
# Start a worker by calling: <%= @web_namespace %>.Worker.start_link(arg)
16-
# {<%= @web_namespace %>.Worker, arg}
13+
# {<%= @web_namespace %>.Worker, arg},
14+
# Start to serve requests, typically the last entry
15+
<%= @endpoint_module %>
1716
]
1817

1918
# See https://hexdocs.pm/elixir/Supervisor.html

0 commit comments

Comments
 (0)