Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to load plugin in version 1.8 #4096

Closed
2 tasks done
guy-frontegg opened this issue Feb 2, 2025 · 2 comments
Closed
2 tasks done

unable to load plugin in version 1.8 #4096

guy-frontegg opened this issue Feb 2, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@guy-frontegg
Copy link

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

When upgrading to version 1.8 and have argo rollout load plugin

 trafficRouterPlugins: |-
        - name: "argoproj-labs/gatewayAPI"
          location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.2.0/gateway-api-plugin-linux-amd64"

argo rollout pod throws this error
time="2025-02-02T15:06:33Z" level=fatal msg="Failed to init config: failed to unmarshal traffic router plugins while initializing: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal object into Go value of type []types.PluginItem"
To Reproduce

Simply add the rollouts-plugin-trafficrouter-gatewayapi via config map

Expected behavior

Should load up the plugin

Screenshots

Version

New version 1.8

Logs

time="2025-02-02T15:06:33Z" level=fatal msg="Failed to init config: failed to unmarshal traffic router plugins while initializing: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal object into Go value of type []types.PluginItem"

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@guy-frontegg guy-frontegg added the bug Something isn't working label Feb 2, 2025
@zachaller
Copy link
Collaborator

I was able to download this just fine, might want to double check spacing maybe?

data: 
  trafficRouterPlugins: |- 
    - name: "argoproj-labs/gatewayAPI" 
      location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.2.0/gateway-api-plugin-linux-amd64"
time="2025-02-03T10:23:48-06:00" level=info msg="GET https://127.0.0.1:63692/api/v1/namespaces/argo-rollouts/configmaps/argo-rollouts-config 200 OK in 2 milliseconds"
time="2025-02-03T10:23:48-06:00" level=info msg="Downloading plugin argoproj-labs/gatewayAPI from: https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.2.0/gateway-api-plugin-linux-amd64"
time="2025-02-03T10:24:01-06:00" level=info msg="Download complete, it took 13.116564166s"

@guy-frontegg
Copy link
Author

So, I started the Argo rollout without the plugin, added it after the pods were ready, and it worked. After restarting, it continued to work, so I guess all is well in the state of Denemark.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants