fix: allow gitlab eventsource to work without projects or groups (#3508)

Signed-off-by: Priscillesg <[email protected]>

Author: Priscillesg

api/jsonschema/schema.json

@@ -2087,7 +2087,7 @@
           "type": "string"
         },
         "projects": {
-          "description": "List of project IDs or project namespace paths like \"whynowy/test\". Projects and groups cannot be empty at the same time.",
+          "description": "List of project IDs or project namespace paths like \"whynowy/test\". If neither a project nor a group is defined, the EventSource will not manage webhooks.",
           "items": {
             "type": "string"
           },

api/openapi-spec/swagger.json

@@ -10099,8 +10099,9 @@ event payload.
 <em>(Optional)</em>
 <p>
 
-List of project IDs or project namespace paths like “whynowy/test”.
-Projects and groups cannot be empty at the same time.
+List of project IDs or project namespace paths like “whynowy/test”. If
+neither a project nor a group is defined, the EventSource will not
+manage webhooks.
 </p>
 
 </td>

docs/APIs.md

@@ -858,7 +858,8 @@ type GitlabEventSource struct {
 	// Metadata holds the user defined metadata which will passed along the event payload.
 	// +optional
 	Metadata map[string]string `json:"metadata,omitempty" protobuf:"bytes,9,rep,name=metadata"`
-	// List of project IDs or project namespace paths like "whynowy/test". Projects and groups cannot be empty at the same time.
+	// List of project IDs or project namespace paths like "whynowy/test".
+	// If neither a project nor a group is defined, the EventSource will not manage webhooks.
 	// +optional
 	Projects []string `json:"projects,omitempty" protobuf:"bytes,10,rep,name=projects"`
 	// SecretToken references to k8 secret which holds the Secret Token used by webhook config

pkg/apis/events/v1alpha1/eventsource_types.go

@@ -30,9 +30,6 @@ func validate(eventSource *v1alpha1.GitlabEventSource) error {
 	if eventSource == nil {
 		return v1alpha1.ErrNilEventSource
 	}
-	if len(eventSource.GetProjects()) == 0 && len(eventSource.GetGroups()) == 0 {
-		return fmt.Errorf("projects and groups cannot be empty at the same time")
-	}
 	if eventSource.Events == nil {
 		return fmt.Errorf("events can't be empty")
 	}

pkg/apis/events/v1alpha1/generated.proto

@@ -34,7 +34,6 @@ func TestValidateEventSource(t *testing.T) {
 
 	err := listener.ValidateEventSource(context.Background())
 	assert.Error(t, err)
-	assert.Equal(t, "projects and groups cannot be empty at the same time", err.Error())
 
 	content, err := os.ReadFile(fmt.Sprintf("%s/%s", sources.EventSourceDir, "gitlab.yaml"))
 	assert.Nil(t, err)