Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gitlab support #141

Open
zachaller opened this issue Dec 3, 2024 · 4 comments
Open

feat: add gitlab support #141

zachaller opened this issue Dec 3, 2024 · 4 comments

Comments

@zachaller
Copy link
Contributor

No description provided.

@robinlieb
Copy link
Contributor

@zachaller
Working in that feature, created a draft pull request in #205 for that.
I have two questions that I would like to clarify:

  1. GitLab has a slightly different approach when it comes to orgs, which is also the possibility to have subgroups, so a repo could have the slug (.../group/subgroup/project). To cover that (or make it more clear), I have created dedicated objects for the git repository CR for each SCM. This would mean that it breaks the current approach. Technically this could also be covered with the current implementation, to just put the GitLab namespace in the owner property. Is there any preference on one approach?
  2. For the commit phase there are currently three phases. From the comments if the Phase property I guess the intention was to have one project generic specification and then have each SCM provider implement its own logic the map these. Is that right?

@crenshaw-dev
Copy link
Contributor

On 1, I like the spec being super explicit, I think it's a better user experience. At this early stage, the breaking change is probably fine. But curious if @zachaller thinks this would be a good opportunity to practice our API versioning skills.

On 2, that's exactly correct. The phases are meant to generally map to their SCM-specific equivalents.

@zachaller
Copy link
Contributor Author

@robinlieb thanks for the contributions

On 1, we did talk about the breaking change in the API and with how early the project is we are good with that change for now until we setup proper conversion webhook infrastructure.

@robinlieb
Copy link
Contributor

Thanks for the clarification and the initial review!
For the git username I created a dedicated pr (#206).
I try to resolve the comments in #205 by the end of this week, but will update the PR once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants