feat: log gitlab rate limits only when available

Signed-off-by: Robin Lieb <[email protected]>

Author: robinlieb

Diff for: internal/scms/gitlab/commit_status.go

@@ -60,7 +60,7 @@ func (cs *CommitStatus) Set(ctx context.Context, commitStatus *v1alpha1.CommitSt
 		return nil, fmt.Errorf("failed to create status: %w", err)
 	}
 
-	logGitLabRatelimits(
+	logGitLabRateLimitsIfAvailable(
 		logger,
 		repo.Spec.ScmProviderRef.Name,
 		resp,

Diff for: internal/scms/gitlab/pullrequest.go

@@ -59,7 +59,7 @@ func (pr *PullRequest) Create(ctx context.Context, title, head, base, desc strin
 		return "", fmt.Errorf("failed to create pull request: %w", err)
 	}
 
-	logGitLabRatelimits(
+	logGitLabRateLimitsIfAvailable(
 		logger,
 		prObj.Spec.RepositoryReference.Name,
 		resp,
@@ -101,7 +101,7 @@ func (pr *PullRequest) Update(ctx context.Context, title, description string, pr
 		return fmt.Errorf("failed to update merge request: %w", err)
 	}
 
-	logGitLabRatelimits(
+	logGitLabRateLimitsIfAvailable(
 		logger,
 		prObj.Spec.RepositoryReference.Name,
 		resp,
@@ -142,7 +142,7 @@ func (pr *PullRequest) Close(ctx context.Context, prObj *v1alpha1.PullRequest) e
 		return fmt.Errorf("failed to close merge request: %w", err)
 	}
 
-	logGitLabRatelimits(
+	logGitLabRateLimitsIfAvailable(
 		logger,
 		prObj.Spec.RepositoryReference.Name,
 		resp,
@@ -186,7 +186,7 @@ func (pr *PullRequest) Merge(ctx context.Context, commitMessage string, prObj *v
 		return fmt.Errorf("failed to merge request: %w", err)
 	}
 
-	logGitLabRatelimits(
+	logGitLabRateLimitsIfAvailable(
 		logger,
 		prObj.Spec.RepositoryReference.Name,
 		resp,
@@ -212,7 +212,7 @@ func (pr *PullRequest) FindOpen(ctx context.Context, prObj *v1alpha1.PullRequest
 		return false, fmt.Errorf("failed to list pull requests: %w", err)
 	}
 
-	logGitLabRatelimits(
+	logGitLabRateLimitsIfAvailable(
 		logger,
 		prObj.Spec.RepositoryReference.Name,
 		resp,

Diff for: internal/scms/gitlab/utils.go

@@ -6,18 +6,24 @@ import (
 	gitlab "gitlab.com/gitlab-org/api/client-go"
 )
 
-func logGitLabRatelimits(
+func logGitLabRateLimitsIfAvailable(
 	logger logr.Logger,
 	scmProvider string,
 	resp *gitlab.Response,
 ) {
-	logger.Info("GitLab rate limits",
-		"scmProvider", scmProvider,
-		"limit", resp.Header.Get("Ratelimit-Limit"),
-		"remaining", resp.Header.Get("Ratelimit-Remaining"),
-		"reset", resp.Header.Get("Ratelimit-Reset"),
-		"url", resp.Request.URL,
-	)
+	limit := resp.Header.Get("Ratelimit-Limit")
+	remaining := resp.Header.Get("Ratelimit-Remaining")
+	reset := resp.Header.Get("Ratelimit-Reset")
+
+	if limit != "" || remaining != "" || reset != "" {
+		logger.Info("GitLab rate limits",
+			"scmProvider", scmProvider,
+			"limit", limit,
+			"remaining", remaining,
+			"reset", reset,
+			"url", resp.Request.URL.String(),
+		)
+	}
 }
 
 func mapMergeRequestState(gl string) v1alpha1.PullRequestState {