Skip to content

Commit 3a7014e

Browse files
committed
Use non-version specific reference URLs for tool version workflow variables
GitHub Actions actions are used by the workflows to set up development tools in the runner workspace. In order to facilitate updates to new versions of these tools, we set the version to be set up via environment variables at the top of the workflow. Since this variable definition is separate from the step using the action, it might not be immediately apparent to the maintainer which version syntaxes are supported. For this reason, comments were added with the URL to the relevant section of the consuming action's documentation. Previously, these URLs were made to point to the version of the documentation that matched the version of the action in use by the workflow. Since we only use a major version ref, the expectation was that this would only need to be updated rarely. However, it turned out that the major version bump cycle is significantly shorter than expected. In addition, it is easy to forget the update because action version update PRs are provided by Dependabot, which obviously won't update the URLs in the comments. So it will be best to use a URL that points to the documentation at the tip of the default branch of the action repository. The likelihood of the documentation provided by this URL not matching the behavior of the release version of the action in use is likely less than it is for an outdated URL.
1 parent fccad7d commit 3a7014e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ env:
77
ARTIFACT_NAME: dist
88
# The project's folder on Arduino's download server for uploading builds
99
AWS_PLUGIN_TARGET: /tools/
10-
# See: https://github.com/actions/setup-python/tree/v3#available-versions-of-python
10+
# See: https://github.com/actions/setup-python/tree/main#available-versions-of-python
1111
PYTHON_VERSION: "3.7"
1212
MCUBOOT_PATH: ${{ github.workspace }}/mcuboot
1313
IMGTOOL_PACKING_PATH: ${{ github.workspace }}/imgtool-packing

0 commit comments

Comments
 (0)