Skip to content

requests 2.32.0 is yanked, cannot build. #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
SJang1 opened this issue Nov 26, 2024 · 3 comments
Closed
3 tasks done

requests 2.32.0 is yanked, cannot build. #333

SJang1 opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@SJang1
Copy link

SJang1 commented Nov 26, 2024

Describe the problem

I see that there was version changes on #274 which did made requests 2.32.0, however it seems to be like this version have a CVE issue that made blocking the project to build.

Gets error on Actions setup process

To reproduce

Set yaml to use uses: arduino/[email protected] or higher version.
current latest (1.1.2) still uses requests 2.32.0 and it makes build unavailable

Expected behavior

Build builds correctly

'arduino/compile-sketches' version

1.1.1 or 1.1.2 or latest

Additional context

  creating virtual environment...
  installing poetry from spec 'poetry==1.4.0'...
  done! ✨ 🌟 ✨
    installed package poetry 1.4.0, installed using Python 3.11.2
    These apps are now globally available
      - poetry
  Creating virtualenv compilesketches--acYsnh9-py3.11 in /home/runner/.cache/pypoetry/virtualenvs
  Installing dependencies from lock file
  Package operations: 20 installs, 0 updates, 0 removals
    • Installing pycparser (2.21)
    • Installing cffi (1.15.1)
    • Installing certifi (2023.7.22)
    • Installing charset-normalizer (3.1.0)
    • Installing cryptography (42.0.4)
    • Installing idna (3.7)
    • Installing smmap (5.0.0)
    • Installing urllib3 (1.26.18)
    • Installing wrapt (1.15.0)
    • Installing deprecated (1.2.13)
    • Installing gitdb (4.0.10)
    • Installing pyjwt (2.6.0)
    • Installing pynacl (1.5.0)
    • Installing requests (2.32.0)
    • Installing typing-extensions (4.8.0)
    • Installing gitpython (3.1.43)
    • Installing pygithub (2.3.0)
    • Installing pyserial (3.5)
    • Installing semver (3.0.2)
    • Installing pyyaml (6.0.1)
  Warning: The file chosen for install of requests 2.32.0 (requests-2.32.0-py3-none-any.whl) is yanked. Reason for being yanked: Yanked due to conflicts with CVE-2024-35195 mitigation
  Installing the current project: compilesketches (0.0.0)

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details
@SJang1 SJang1 added the type: imperfection Perceived defect in any part of project label Nov 26, 2024
@per1234 per1234 self-assigned this Nov 26, 2024
@per1234
Copy link
Collaborator

per1234 commented Nov 26, 2024

Hi @SJang1. This is only a warning, not an error. Your "it makes build unavailable" claim is false. Arduino uses the action in hundreds of libraries and it is fully functional

Are you actually experiencing a problem while using the arduino/compile-sketches action? If so, please provide a detailed description of the problem, including instructions I can follow to reproduce it. If you are using the action in a workflow in a public repository, it will be helpful if you provide a link to a workflow run in the repository that demonstrates the problem.

@per1234 per1234 added status: waiting for information More information must be provided before work can proceed topic: infrastructure Related to project infrastructure labels Nov 26, 2024
@SJang1
Copy link
Author

SJang1 commented Nov 26, 2024

It actually blocks from building, when I clone the repo and change the version of it up, change uses to my repo@main and run, it successes.

@SJang1
Copy link
Author

SJang1 commented Nov 26, 2024

Oh, found that it can keep going done by just warning, I just found out another problem, and seems like there was my mistake.

Thanks!

@SJang1 SJang1 closed this as completed Nov 26, 2024
@per1234 per1234 added conclusion: invalid Issue/PR not valid and removed status: waiting for information More information must be provided before work can proceed labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants