Localization data update procedure is undocumented #2724
Labels
topic: documentation
Related to documentation for the project
type: imperfection
Perceived defect in any part of project
Describe the problem
I created a pull request (#2718) that includes a new translation key. The "Check Internationalization" GitHub Actions workflow run failed on the pull request:
I had to carefully study the logs of the failed check in order to determine that I needed to run the
i18n:generate
Yarn script to resolve this.The addition of new i18n keys to the codebase will be a common occurrence for contributors proposing new features, yet there is no mention of the requirement to run this command in the Development Guide, or anywhere else in the documentation.
Expected behavior
Any common operation that is required of contributors is documented.
Instructions for the procedure the contributor must follow to update the localization data files after adding an internationalization key to the codebase, or removing a key from the codebase should be provided in the "Development Guide" documentation:
https://github.com/arduino/arduino-ide/blob/main/docs/development.md#development-guide
It would also be good to ensure that information is easily discovered by the reader of the "Pull Request Guide".
Arduino IDE version
0f9f0d0
Additional context
In addition to the system that must be used by the contributor, the repository also contains a system for pushing the updated localization files to Transifex and pulling the localization data from the Transifex project.
Those contributing to the application codebase don't need to use this system, as it operates independently, but the project maintainers do need to maintain the system, so they do need to understand how it works. There is currently no documentation of this system. It would be useful to add an overview of the full i18n/l10n system. The appropriate place for that information would be in the "internal" documentation:
https://github.com/arduino/arduino-ide/tree/main/docs/internal
Here is a rough overview:
i18n:generate
Yarn script to update the localization data files.i18n:push
Yarn script, which uploads theen.json
file (only that file) to the "Arduino IDE 2.0" Transifex project.i18n:pull
Yarn script, which pulls the localization data from Transifex.Related
Issue checklist
The text was updated successfully, but these errors were encountered: