Missing translation for "Save"

[Sinclair-ZX81]

Describe the problem

To reproduce

1. Select File > Preferences... (or Arduino > Settings... for macOS users) from the Arduino IDE menus.
   The "Preferences" dialog will open.
2. Select "Deutsch" from the "Language" menu.
   ⓘ This language/locale was chosen arbitrarily for the demo. The fault occurs with all non-English locales.
3. Click the "OK" button.
   The "Preferences" dialog will close.
4. Open the "Datei" ("File") menu.

🐛 The menu item label is "Save" instead of the localized "Speichern".

Expected behavior

All strings for which there is localization data are localized in the Arduino IDE UI.

Arduino IDE version

Original report

2.2.1 and 2.2.2-nightly-20230903

Last verified with

2.3.6

Operating system

Windows

Operating system version

Windows 10 x64

Additional context

Related

• fix missing i18n messages in IDE menu #2215
• Incomplete Dutch translation in menu bar #2616
• "Paste" menu item is not internationalized #2702
• Add missing translations #1431
• Missing translation in Theia's view-container context menu #1498

Additional reports

• Missing translation for "Save" #2213 (comment)

---

Keywords

• localization

• localized

• l10n

• internationalization

• internationalized

• i18n

• translate

• translation

• translator

Issue checklist

• I searched for previous reports in the issue tracker
• I verified the problem still occurs when using the latest nightly build
• My report contains all necessary details

[per1234]

Thanks for reporting this @Sinclair-ZX81.

I confirm that there was a regression in the localization of the File > Save menu item. I bisected the regression to 192aac5, where the language packs were bumped from 1.53.2 to 1.70.0.

The localization data key for the menu item is set here:

arduino-ide/arduino-ide-extension/src/browser/contributions/save-sketch.ts

Line 28 in 0f9f0d0

label: nls.localize('vscode/fileCommands/save', 'Save'),

The data is here in version 1.53.2 of the language pack:

https://github.com/microsoft/vscode-loc/blob/295dfb35491adc41df4b89e0d839086131a34257/i18n/vscode-language-pack-de/translations/main.i18n.json#L5000

		"vs/workbench/contrib/files/browser/fileCommands": {
			"saveAs": "Speichern unter...",
			"save": "Speichern",

Without explanation of the reason for the breaking change, the data was moved in the language packs from vs/workbench/contrib/files/browser/fileCommands/save to vs/workbench/contrib/files/browser/fileConstants/save by microsoft/vscode-loc@e36740c:

https://github.com/microsoft/vscode-loc/blob/a51eba0bb6e14e9b26cb7b5fed1aeca520552010/i18n/vscode-language-pack-de/translations/main.i18n.json#L6189

		"vs/workbench/contrib/files/browser/fileCommands": {
			"discard": "Verwerfen",
			"genericRevertError": "Fehler beim Zurücksetzen von '{0}': {1}",
			"genericSaveError": "Fehler beim Speichern von \"{0}\": {1}",
			"modifiedLabel": "{0} (in Datei) ↔ {1}",
			"retry": "Wiederholen"
		},
		"vs/workbench/contrib/files/browser/fileConstants": {
			"newUntitledFile": "Neue unbenannte Datei",
			"removeFolderFromWorkspace": "Ordner aus dem Arbeitsbereich entfernen",
			"save": "Speichern",

And the key is also updated to vs/workbench/contrib/files/browser/fileConstants/save in the Theia package:

https://github.com/eclipse-theia/theia/blob/v1.39.0/packages/core/src/common/i18n/nls.metadata.json#L9130-L9132

		"vs/workbench/contrib/files/browser/fileConstants": [
			"saveAs",
			"save",