Skip to content

IDE2 should not toast an error notification when users cancel the library install dialog #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kittaakos opened this issue May 11, 2023 · 0 comments · Fixed by #2065
Closed
3 tasks done

IDE2 should not toast an error notification when users cancel the library install dialog #2063

kittaakos opened this issue May 11, 2023 · 0 comments · Fixed by #2065
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented May 11, 2023 •
edited
Loading

Describe the problem

Suppose users want to install a library that has one or more dependencies. In that case, IDE2 raises a confirm dialog whether only the library should be installed or the library with all its dependencies. When users close the confirmation dialog (clicking on the X), IDE2 toasts an error message: User abort. This should not happen. The regression has been introduced via #2061.

To reproduce

  • If you have ArduinoIoTCloud installed, uninstall it,
  • Install ArduinoIoTCloud,
  • IDE2 raises the confirmation dialog,
  • Close it with the X,
  • See the error notification.
2063.mp4

Expected behavior

When the user closes the library installation confirmation dialog, nothing happens.

Arduino IDE version

278dd4b

Operating system

macOS

Operating system version

12.3.6

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 11, 2023
@kittaakos kittaakos self-assigned this May 11, 2023
kittaakos pushed a commit that referenced this issue May 11, 2023
fix: show no errors if users cancel lib install
8529696 
Throwing and catching a `UserAbortError` is part of the natural flow.

Closes #2063

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue May 11, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue May 16, 2023
@kittaakos
fix: show no errors if users cancel lib install
ee43a12 
Throwing and catching a `UserAbortError` is part of the natural flow.

Closes #2063

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show no errors if users cancel lib install arduino/arduino-ide
1 participant
@kittaakos