Skip to content

Drop the arduino.window.zoomLevel preference and use Theia's window.zoomLevel instead #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kittaakos opened this issue Nov 9, 2022 · 0 comments · Fixed by #1675
Closed
3 tasks done

Drop the arduino.window.zoomLevel preference and use Theia's window.zoomLevel instead #1657

kittaakos opened this issue Nov 9, 2022 · 0 comments · Fixed by #1675
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved criticality: low Of low impact priority: low Resolution is a low priority topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

Describe the request

IDE2 introduced the arduino.window.zoomLevel preference when Theia could not adjust, store, and restore the zoom level. More recent versions of Theia can do it. Drop the Arduino-specific preference for the window zoom level.

Describe the current behavior

See above.

Arduino IDE version

2.0.1

Operating system

N/A

Operating system version

all

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework labels Nov 9, 2022
@kittaakos kittaakos self-assigned this Nov 9, 2022
@davegarthsimpson davegarthsimpson added criticality: low Of low impact priority: low Resolution is a low priority labels Nov 14, 2022
kittaakos pushed a commit that referenced this issue Nov 14, 2022
chore: Switched to window.zoomLevel preference
9ab0de4 
Deprecated `arduino.window.zoomLevel`.

Closes #1657

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Nov 14, 2022
Merged
4 tasks
@kittaakos kittaakos linked a pull request Nov 15, 2022 that will close this issue
chore: Switched to window.zoomLevel preference #1675
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Nov 23, 2022
chore: Switched to window.zoomLevel preference
09057fa 
Deprecated `arduino.window.zoomLevel`.

Closes #1657

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 29, 2022
chore: Switched to window.zoomLevel preference
c7e97f2 
Deprecated `arduino.window.zoomLevel`.

Closes #1657

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 29, 2022
@kittaakos
chore: Switched to window.zoomLevel preference
87109e6 
Deprecated `arduino.window.zoomLevel`.

Closes #1657

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved criticality: low Of low impact priority: low Resolution is a low priority topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Switched to window.zoomLevel preference arduino/arduino-ide
3 participants
@kittaakos @per1234 @davegarthsimpson