Skip to content

Serial Plotter - Set maximum dataset points #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
InstantMuffin opened this issue Aug 8, 2022 · 1 comment
Closed
3 tasks done

Serial Plotter - Set maximum dataset points #1308

InstantMuffin opened this issue Aug 8, 2022 · 1 comment
Assignees
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@InstantMuffin
Copy link
Contributor

InstantMuffin commented Aug 8, 2022

Describe the request

I would love for the Serial Plotter to show more than just the last 50 dataset points as it currently does.
I have not found an option to set this, and I believe a simple slider (from lets say 10-500) would do.

EDIT:
I would love to do this myself, and I think just changing the buffer's size statically is as easy as altering this line:
https://github.com/arduino/arduino-serial-plotter-webapp/blob/04a460e0c21609a63c4064f561990c0128c5a0ed/src/ChartPlotter.tsx#L46
However upon finding this I noticed that this is actually its own app with its own repo and I am not sure how to inject an altered dependency/module when compiling arduino-ide (I assume it somehow fetches these apps as packages stuffed into respective singular files as a simple file search doesn't yield any results).
That said it raises the question if this issue is best opened here, or if I should repost this in the app's repo. I apologize for any inconvenience opening this issue here might have caused.

Describe the current behavior

The Serial Plotter currently only plots the last 50 dataset points.

Arduino IDE version

"All of them"

Operating system

N/A

Operating system version

XUbuntu 22.04 LTS

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@InstantMuffin InstantMuffin added the type: enhancement Proposed improvement label Aug 8, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 9, 2022

Hi @InstantMuffin . Thanks for taking the time to submit an issue.

I see we have another report about this at #803.

It is best to have only a single issue per subject so we can consolidate all relevant discussion to one place, so I'll go ahead and close this in favor of the other.

If you end up with additional information to share, feel free to comment in the other thread.

it raises the question if this issue is best opened here, or if I should repost this in the app's repo.

It is a good question. I don't have enough knowledge about arduino-serial-plotter-webapp to say whether this proposal would be implemented purely in its code base, or whether changes are also needed in the Arduino IDE code base.

If the former, I would like to transfer the issue to the other repository (GitHub now has a feature to allow those with write permissions to do that instead of having to re-create the issue).

I am not sure how to inject an altered dependency/module when compiling arduino-ide (I assume it somehow fetches these apps as packages stuffed into respective singular files

Perhaps it indicates an area for improvement in the Arduino IDE documentation.

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
@per1234 per1234 added conclusion: duplicate Has already been submitted topic: code Related to content of the project itself labels Aug 9, 2022
@per1234 per1234 self-assigned this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants