feat: notification progress for pull/push

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-contributions.ts

@@ -266,8 +266,12 @@ export class CloudSketchbookContribution extends CloudSketchContribution {
     if (!CurrentSketch.isValid(currentSketch)) {
       return undefined;
     }
-    const dataDirUri = this.configServiceClient.tryGetDataDirUri();
     // cannot determine if the sketch is in the cloud cache folder
+    const dataDirUri = this.configServiceClient.tryGetDataDirUri();
+    if (!dataDirUri) {
+      return undefined;
+    }
+    // sketch is not in the cache folder
     if (!this.createFeatures.isCloud(currentSketch, dataDirUri)) {
       return undefined;
     }

Diff for: arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree.ts

@@ -32,6 +32,7 @@ import { posix, splitSketchPath } from '../../create/create-paths';
 import { Create } from '../../create/typings';
 import { nls } from '@theia/core/lib/common';
 import { ApplicationConnectionStatusContribution } from '../../theia/core/connection-status-service';
+import { ExecuteWithProgress } from '../../../common/protocol/progressible';
 
 const MESSAGE_TIMEOUT = 5 * 1000;
 const deepmerge = require('deepmerge').default;
@@ -144,7 +145,7 @@ export class CloudSketchbookTree extends SketchbookTree {
       this.messageService.info(
         nls.localize(
           'arduino/cloud/donePulling',
-          'Done pulling ‘{0}’.',
+          "Done pulling '{0}'.",
           node.fileStat.name
         ),
         {
@@ -212,7 +213,7 @@ export class CloudSketchbookTree extends SketchbookTree {
       this.messageService.info(
         nls.localize(
           'arduino/cloud/donePushing',
-          'Done pushing ‘{0}’.',
+          "Done pushing '{0}'.",
           node.fileStat.name
         ),
         {
@@ -324,29 +325,15 @@ export class CloudSketchbookTree extends SketchbookTree {
     state: CloudSketchbookTree.CloudSketchDirNode.State,
     task: (node: CloudSketchbookTree.CloudSketchDirNode) => MaybePromise<T>
   ): Promise<T> {
-    const decoration: WidgetDecoration.TailDecoration = {
-      data: `${firstToUpperCase(state)}...`,
-      fontData: {
-        color: 'var(--theia-list-highlightForeground)',
-      },
-    };
-    try {
-      node.state = state;
-      this.mergeDecoration(node, { tailDecorations: [decoration] });
-      await this.refresh(node);
-      const result = await task(node);
-      return result;
-    } finally {
-      delete node.state;
-      // TODO: find a better way to attach and detach decorators. Do we need a proper `TreeDecorator` instead?
-      const index = node.decorationData?.tailDecorations?.findIndex(
-        (candidate) => JSON.stringify(decoration) === JSON.stringify(candidate)
-      );
-      if (typeof index === 'number' && index !== -1) {
-        node.decorationData?.tailDecorations?.splice(index, 1);
+    const name = node.uri.path.name;
+    return ExecuteWithProgress.withProgress(
+      `${firstToUpperCase(state)} '${name}'`,
+      this.messageService,
+      async (progress) => {
+        progress.report({ work: { done: 0, total: NaN } });
+        return task(node);
       }
-      await this.refresh(node);
-    }
+    );
   }
 
   private async sync(source: URI, dest: URI): Promise<void> {

Diff for: i18n/en.json

@@ -93,8 +93,8 @@
       "cloudSketchbook": "Cloud Sketchbook",
       "connected": "Connected",
       "continue": "Continue",
-      "donePulling": "Done pulling ‘{0}’.",
-      "donePushing": "Done pushing ‘{0}’.",
+      "donePulling": "Done pulling '{0}'.",
+      "donePushing": "Done pushing '{0}'.",
       "embed": "Embed:",
       "emptySketchbook": "Your Sketchbook is empty",
       "goToCloud": "Go to Cloud",