Skip to content

Commit 1365454

Browse files
committed
Deduplicate S3 publishing determination code in build workflow
The "Arduino IDE" GitHub Actions workflow uploads the nightly and release builds to Amazon S3, from which they are downloaded by the auto-update as well as directly by users via the links on the "Software" page of arduino.cc. The workflow can also be useful in forks. Either by those who want to test contributions staged in their fork prior to submitting a PR to the parent repo, or by those maintaining a hard fork of the project. Even though these forks wouldn't (and couldn't due to lack of access to the encrypted credential secrets only available to the workflow when ran in a trusted context in Arduino's repo)credentials stored in Arduino's repo) use the S3 upload component of the workflow, they may still find it valuable for continuous integration as well as continuous deployment via the tester builds and release builds the workflow also publishes to the GitHub repository it runs in. For this reason, the workflow contains code to determine whether it should attempt the S3 uploads. Previously that code was duplicated in both the nightly and release publishing jobs of the workflow. Since the workflow already contains a job specifically for the purpose of determining the characteristics of the build being performed and making that information available from single source for use throughout the rest of the workflow, it makes sense to also move the S3 upload determination code to that job.
1 parent 7e1d441 commit 1365454

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/workflows/build.yml

+5-2
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ jobs:
136136
is-release: ${{ steps.determination.outputs.is-release }}
137137
is-nightly: ${{ steps.determination.outputs.is-nightly }}
138138
channel-name: ${{ steps.determination.outputs.channel-name }}
139+
publish-to-s3: ${{ steps.determination.outputs.publish-to-s3 }}
139140
permissions: {}
140141
steps:
141142
- name: Determine the type of build
@@ -166,6 +167,8 @@ jobs:
166167
echo "is-release=$is_release" >> $GITHUB_OUTPUT
167168
echo "is-nightly=$is_nightly" >> $GITHUB_OUTPUT
168169
echo "channel-name=$channel_name" >> $GITHUB_OUTPUT
170+
# Only attempt upload to Amazon S3 if the credentials are available.
171+
echo "publish-to-s3=${{ github.repository == 'arduino/arduino-ide' }}" >> $GITHUB_OUTPUT
169172
170173
select-targets:
171174
needs: build-type-determination
@@ -509,7 +512,7 @@ jobs:
509512
- merge-channel-files-complete
510513
- changelog
511514
if: >
512-
github.repository == 'arduino/arduino-ide' &&
515+
needs.build-type-determination.outputs.publish-to-s3 == 'true' &&
513516
needs.build-type-determination.outputs.is-nightly == 'true'
514517
runs-on: ubuntu-latest
515518
steps:
@@ -566,7 +569,7 @@ jobs:
566569
rm "${{ env.JOB_TRANSFER_ARTIFACT }}/stable-linux.yml"
567570
568571
- name: Publish Release [S3]
569-
if: github.repository == 'arduino/arduino-ide'
572+
if: needs.build-type-determination.outputs.publish-to-s3 == 'true'
570573
uses: docker://plugins/s3
571574
env:
572575
PLUGIN_SOURCE: '${{ env.JOB_TRANSFER_ARTIFACT }}/*'

0 commit comments

Comments
 (0)