Skip to content

Consider adding "Configure Origins" to the UI #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joachimhs opened this issue May 20, 2019 · 5 comments
Closed

Consider adding "Configure Origins" to the UI #380

joachimhs opened this issue May 20, 2019 · 5 comments
Assignees
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@joachimhs
Copy link

No description provided.

@joachimhs
Copy link
Author

In order for third-party developers to use the Arduino-Create-Agent for their arduino-based websites, the end-user need to edit the config.ini file and add in the domain.

This is something most end-users won't be able to easily do, especially if the target is educational and schools.

It would be very handy if the UI of the Create Agent enabled the end user to easily add in websites that they would like to enable to create agent for.

Screen Shot 2019-05-20 at 11 44 34

@gvarisco gvarisco changed the title Consider adding "Cofigure Origins" to the UI Consider adding "Configure Origins" to the UI Jun 1, 2019
@umbynos umbynos added the type: enhancement Proposed improvement label Feb 12, 2021
@umbynos
Copy link
Contributor

umbynos commented Feb 12, 2021

Thank you for your suggestion, we will add it to the project backlog when we'll have some bandwidth 😁

@phptuts
Copy link

phptuts commented Jan 29, 2022

@umbynos Would you be open to a pr for this? If so would you want it to open up a webpage to configure this feature?

@umbynos
Copy link
Contributor

umbynos commented Feb 3, 2022

Hi @phptuts, I asked this question to our the security team and this is what they told me:

Including a domain in the list of origin that can communicate with the arduino agent implies a high level of trust of the domain. Since we cannot ensure that in this specific case, ElectroBlocks is currently not a partner or anything alike, we should not include it in the official code.

@per1234
Copy link
Contributor

per1234 commented Feb 8, 2022

Closing as declined according to the explanation provided in the other issue:

Having a custom menu item to configure just the origins is definitely not a viable solution as we are creating and exception for a specific configuration that can and should be set in the config.ini file.

Also, adding a custom web ui has been determined not to be feasible because of this answer

@per1234 per1234 closed this as completed Feb 8, 2022
@per1234 per1234 added conclusion: declined Will not be worked on topic: code Related to content of the project itself labels Feb 8, 2022
@per1234 per1234 self-assigned this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

4 participants