Don't return an error if the download tool fails

matteosuppo · matteosuppo · commit 8f8e4c016f5f · 2017-09-14T11:04:00.000+02:00
windows-driver can fail on non-windows
diff --git a/tools/download.go b/tools/download.go
@@ -182,7 +182,8 @@ func (t *Tools) Download(pack, name, version, behaviour string) error {
 	correctTool, correctSystem := findTool(pack, name, version, data)
 
 	if correctTool.Name == "" || correctSystem.URL == "" {
-		return errors.New("We couldn't find a tool with the name " + name + " and version " + version + " packaged by " + pack)
+		t.Logger("We couldn't find a tool with the name " + name + " and version " + version + " packaged by " + pack)
+		return nil
 	}
 
 	key := correctTool.Name + "-" + correctTool.Version

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,8 @@ func (t *Tools) Download(pack, name, version, behaviour string) error {`
`182`	`182`	`correctTool, correctSystem := findTool(pack, name, version, data)`
`183`	`183`
`184`	`184`	`if correctTool.Name == "" \|\| correctSystem.URL == "" {`
`185`		`- return errors.New("We couldn't find a tool with the name " + name + " and version " + version + " packaged by " + pack)`
	`185`	`+ t.Logger("We couldn't find a tool with the name " + name + " and version " + version + " packaged by " + pack)`
	`186`	`+ return nil`
`186`	`187`	`}`
`187`	`188`
`188`	`189`	`key := correctTool.Name + "-" + correctTool.Version`