Refactor preconditions checks

Author: MatteoPologruto

commands/service_profile_init.go

@@ -33,17 +33,12 @@ import (
 // InitProfile creates a new project file if it does not exist. If a profile name with the associated FQBN is specified,
 // it is added to the project.
 func (s *arduinoCoreServerImpl) InitProfile(ctx context.Context, req *rpc.InitProfileRequest) (*rpc.InitProfileResponse, error) {
-	sketchPath := paths.New(req.GetSketchPath())
-	projectFilePath, err := sketchPath.Join("sketch.yaml").Abs()
-	if err != nil {
-		return nil, err
-	}
-
 	// Returns an error if the main file is missing from the sketch so there is no need to check if the path exists
-	sk, err := sketch.New(sketchPath)
+	sk, err := sketch.New(paths.New(req.GetSketchPath()))
 	if err != nil {
 		return nil, err
 	}
+	projectFilePath := sk.GetProjectPath()
 
 	if !projectFilePath.Exist() {
 		err := projectFilePath.WriteFile([]byte("profiles: {}\n"))

commands/service_profile_lib_add.go

@@ -27,17 +27,12 @@ import (
 
 // ProfileLibAdd adds a library to the specified profile or to the default profile.
 func (s *arduinoCoreServerImpl) ProfileLibAdd(ctx context.Context, req *rpc.ProfileLibAddRequest) (*rpc.ProfileLibAddResponse, error) {
-	sketchPath := paths.New(req.GetSketchPath())
-	projectFilePath, err := sketchPath.Join("sketch.yaml").Abs()
-	if err != nil {
-		return nil, err
-	}
-
 	// Returns an error if the main file is missing from the sketch so there is no need to check if the path exists
-	sk, err := sketch.New(sketchPath)
+	sk, err := sketch.New(paths.New(req.GetSketchPath()))
 	if err != nil {
 		return nil, err
 	}
+	projectFilePath := sk.GetProjectPath()
 
 	// If no profile is specified, try to use the default one
 	profileName := sk.Project.DefaultProfile

commands/service_profile_lib_remove.go

@@ -26,17 +26,12 @@ import (
 
 // ProfileLibRemove removes a library from the specified profile or from the default profile.
 func (s *arduinoCoreServerImpl) ProfileLibRemove(ctx context.Context, req *rpc.ProfileLibRemoveRequest) (*rpc.ProfileLibRemoveResponse, error) {
-	sketchPath := paths.New(req.GetSketchPath())
-	projectFilePath, err := sketchPath.Join("sketch.yaml").Abs()
-	if err != nil {
-		return nil, err
-	}
-
 	// Returns an error if the main file is missing from the sketch so there is no need to check if the path exists
-	sk, err := sketch.New(sketchPath)
+	sk, err := sketch.New(paths.New(req.GetSketchPath()))
 	if err != nil {
 		return nil, err
 	}
+	projectFilePath := sk.GetProjectPath()
 
 	// If no profile is specified, try to use the default one
 	profileName := sk.Project.DefaultProfile

commands/service_profile_set_default.go

@@ -30,17 +30,12 @@ func (s *arduinoCoreServerImpl) ProfileSetDefault(ctx context.Context, req *rpc.
 		return nil, &cmderrors.MissingProfileError{}
 	}
 
-	sketchPath := paths.New(req.GetSketchPath())
-	projectFilePath, err := sketchPath.Join("sketch.yaml").Abs()
-	if err != nil {
-		return nil, err
-	}
-
 	// Returns an error if the main file is missing from the sketch so there is no need to check if the path exists
-	sk, err := sketch.New(sketchPath)
+	sk, err := sketch.New(paths.New(req.GetSketchPath()))
 	if err != nil {
 		return nil, err
 	}
+	projectFilePath := sk.GetProjectPath()
 
 	if _, err := sk.GetProfile(req.GetProfileName()); err != nil {
 		return nil, err