Skip to content

Added read functions to the LiquidCrystal library #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agdl opened this issue Jul 12, 2016 · 6 comments
Closed

Added read functions to the LiquidCrystal library #7

agdl opened this issue Jul 12, 2016 · 6 comments
Assignees
Labels
type: enhancement Proposed improvement

Comments

@agdl
Copy link
Member

agdl commented Jul 12, 2016

From @Chisalita on July 24, 2013 13:12

Added functions to read data from LCD, to delete last character, to
delete a character at specified position, get current position, get
character from a position and get more characters at once, making it
faster.

Review on Reviewable

Copied from original issue: arduino/Arduino/pull/1517

@agdl
Copy link
Member Author

agdl commented Jul 12, 2016

From @Chisalita on September 7, 2013 18:56

If there are any problems please tell me. I really want to know why it dose not get merged, with all my respect I appreciate your decision. Thank you for the time!

@agdl
Copy link
Member Author

agdl commented Jul 12, 2016

From @ArduinoBot on August 22, 2014 11:51

Can I build this pull request?

@agdl
Copy link
Member Author

agdl commented Jul 12, 2016

From @Chisalita on August 22, 2014 18:54

If you ask for my permission or something like that, then sure you can. If you ask in order to know that it works correctly, I can say that it was tested on my Uno before making the pull request.

@agdl
Copy link
Member Author

agdl commented Jul 12, 2016

From @ffissore on August 22, 2014 20:52

@Chisalita sorry for the comment from arduinobot. we are setting up automated build of all PRs, so that we can provide a downloadable version of the patched IDE

@agdl
Copy link
Member Author

agdl commented Jul 12, 2016

From @andresn on September 14, 2014 4:45

👍 thanks for this!

@agdl
Copy link
Member Author

agdl commented Jul 12, 2016

From @matthijskooijman on September 14, 2014 10:3

I just noticed this PR. I like what it does, so I did a course review of the code. I've added some inline comments in the commit about things I think need to be changed. Overall, I think that the new functions added do not fit in the style of the other Arduino APIs completely and need some improvement. Also, you've removed a lot of trailing spaces (your editor probably did that) which are completely unrelated to the commit at hand and thus complicate review. I'm all for removing trailing whitespace, but you should do it in a separate commit then (which only changes whitespace). Alternatively, configure your editor to leave the whitespace alone. In either case, please update this pullrequest to remove the whitespace changes from the main commit (note that you can (force-)push to your branch to update this pullrequest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

3 participants