-
Notifications
You must be signed in to change notification settings - Fork 177
Open
Labels
topic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Description
init()
function for some reason calls begin(16, 1)
without any good reason for doing so. init()
is normally called from LiquidCrystal
constructor and begin()
needs to be called from user program before any other code. Current code actually performs double LCD initialization which appears to be harmless but unneeded/time consuming.
LiquidCrystal/src/LiquidCrystal.cpp
Lines 70 to 76 in db84824
if (fourbitmode) | |
_displayfunction = LCD_4BITMODE | LCD_1LINE | LCD_5x8DOTS; | |
else | |
_displayfunction = LCD_8BITMODE | LCD_1LINE | LCD_5x8DOTS; | |
begin(16, 1); | |
} |
Metadata
Metadata
Assignees
Labels
topic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project