bugfix: don't overwrite random memory on flush_buffer()

facchinm · facchinm · commit c6b89faf8a3a · 2025-06-05T15:11:12.000+02:00
diff --git a/src/decoder.h b/src/decoder.h
@@ -263,7 +263,7 @@ class RpcDecoder {
     inline bool buffer_full() const { return _bytes_stored == BufferSize; }
     inline bool buffer_empty() const { return _bytes_stored == 0;}
     inline void flush_buffer() {
-        uint8_t* discard_buf;
+        uint8_t discard_buf[CHUNK_SIZE];
         while (_transport.read(discard_buf, CHUNK_SIZE) > 0);
         _bytes_stored = 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ class RpcDecoder {`
`263`	`263`	`inline bool buffer_full() const { return _bytes_stored == BufferSize; }`
`264`	`264`	`inline bool buffer_empty() const { return _bytes_stored == 0;}`
`265`	`265`	`inline void flush_buffer() {`
`266`		`- uint8_t* discard_buf;`
	`266`	`+ uint8_t discard_buf[CHUNK_SIZE];`
`267`	`267`	`while (_transport.read(discard_buf, CHUNK_SIZE) > 0);`
`268`	`268`	`_bytes_stored = 0;`
`269`	`269`	`}`