Fix write-only properties

Author: facchinm

ArduinoCloudThing.cpp

@@ -87,7 +87,7 @@ void ArduinoCloudThing::compress(CborArray& object, CborBuffer& buffer) {
 
     for (int i = 0; i < list.size(); i++) {
         ArduinoCloudPropertyGeneric *p = list.get(i);
-        if (p->shouldBeUpdated()) {
+        if (p->shouldBeUpdated() && p->canRead()) {
             CborObject child = CborObject(buffer);
             p->append(child);
             CborVariant variant = CborVariant(buffer, child);

ArduinoCloudThing.h

@@ -45,6 +45,7 @@ class ArduinoCloudPropertyGeneric
     virtual bool newData() = 0;
     virtual bool shouldBeUpdated() = 0;
     virtual void updateShadow() = 0;
+    virtual bool canRead();
     virtual ArduinoCloudPropertyGeneric& onUpdate(void(*fn)(void)) = 0;
     virtual ArduinoCloudPropertyGeneric& publishEvery(long seconds) = 0;
     void(*callback)(void) = NULL;
@@ -58,7 +59,8 @@ class ArduinoCloudProperty : public ArduinoCloudPropertyGeneric
         property(_property), name(_name) {}
 
     bool write(T value) {
-        if (permission != READ) {
+        /* permissions are intended as seen from cloud */
+        if (permission & WRITE) {
             property = value;
             return true;
         }
@@ -70,11 +72,16 @@ class ArduinoCloudProperty : public ArduinoCloudPropertyGeneric
     }
 
     T read() {
-        if (permission != WRITE) {
+        /* permissions are intended as seen from cloud */
+        if (permission & READ) {
             return property;
         }
     }
 
+    bool canRead() {
+        return (permission & READ);
+    }
+
     String& getName() {
         return name;
     }
@@ -118,6 +125,9 @@ class ArduinoCloudProperty : public ArduinoCloudPropertyGeneric
     void appendValue(CborObject &cbor);
 
     void append(CborObject &cbor) {
+        if (!canRead()) {
+            return;
+        }
         if (tag != -1) {
             cbor.set("t", tag);
         } else {