Create platform specific systemReset functions and remove system reset from onOTARequest()

Author: pennam

src/utility/ota/OTA-nano-rp2040.cpp

@@ -241,12 +241,15 @@ int rp2040_connect_onOTARequest(char const * ota_url)
      return static_cast<int>(OTAError::RP2040_ErrorUnmount);
   }
 
+  return static_cast<int>(OTAError::None);
+}
+
+void rp2040_connect_systemReset()
+{
   /* Perform the reset to reboot to SFU. */
   mbed_watchdog_trigger_reset();
   /* If watchdog is enabled we should not reach this point */
   NVIC_SystemReset();
-
-  return static_cast<int>(OTAError::None);
 }
 
 #endif /* ARDUINO_NANO_RP2040_CONNECT */

src/utility/ota/OTA-portenta-h7.cpp

@@ -82,7 +82,10 @@ int portenta_h7_onOTARequest(char const * ota_url)
     DEBUG_ERROR("Arduino_Portenta_OTA_QSPI::update() failed with %d", static_cast<int>(ota_portenta_err));
     return static_cast<int>(ota_portenta_err);
   }
+}
 
+void portenta_h7_systemReset()
+{
   /* Perform the reset to reboot - then the bootloader performs the actual application update. */
   NVIC_SystemReset();
 }

src/utility/ota/OTA-samd.cpp

@@ -55,9 +55,13 @@ int samd_onOTARequest(char const * ota_url)
     return static_cast<int>(OTAError::DownloadFailed);
   }
 
+#endif /* OTA_STORAGE_SNU */
+}
+
+void samd_systemReset()
+{
   /* Perform the reset to reboot to SxU. */
   NVIC_SystemReset();
-#endif /* OTA_STORAGE_SNU */
 }
 
 #endif /* ARDUINO_ARCH_SAMD */

src/utility/ota/OTA.h

@@ -56,14 +56,17 @@ enum class OTAError : int
 
 #ifdef ARDUINO_ARCH_SAMD
 int samd_onOTARequest(char const * ota_url);
+void samd_systemReset();
 #endif
 
 #ifdef ARDUINO_NANO_RP2040_CONNECT
 int rp2040_connect_onOTARequest(char const * ota_url);
+void rp2040_connect_systemReset();
 #endif
 
 #if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_PORTENTA_H7_M4)
 int portenta_h7_onOTARequest(char const * ota_url);
+void portenta_h7_systemReset();
 #endif
 
 #endif /* ARDUINO_OTA_LOGIC_H_ */