Skip to content

Commit 46b775f

Browse files
authored
Enhancement: Update DI NuGet package, get web driver version programmatically in tests (#83)
* Replace hardcoded chromedriver version with WebDriverManager-based solution * Update Microsoft.Extensions.DependencyInjection nuget packages * Update azure-pipelines.yml for Azure Pipelines 'github.com_aqualityautomation' github connection
1 parent 43d6947 commit 46b775f

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Aquality.Selenium.Core.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
</None>
4444
</ItemGroup>
4545
<ItemGroup>
46-
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.8" />
47-
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.1.8" />
46+
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.9" />
47+
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.1.9" />
4848
<PackageReference Include="NLog" Version="4.7.5" />
4949
<PackageReference Include="Selenium.Support" Version="3.141.0" />
5050
<PackageReference Include="Selenium.WebDriver" Version="3.141.0" />

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/AqualityServices.cs

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
using Aquality.Selenium.Core.Configurations;
33
using Aquality.Selenium.Core.Utilities;
44
using Microsoft.Extensions.DependencyInjection;
5+
using Microsoft.Win32;
56
using System;
7+
using System.Diagnostics;
68
using WebDriverManager;
79
using WebDriverManager.DriverConfigs.Impl;
10+
using WebDriverManager.Helpers;
811

912
namespace Aquality.Selenium.Core.Tests.Applications.Browser
1013
{
@@ -33,8 +36,7 @@ private static ChromeApplication StartChrome(IServiceProvider services)
3336
{
3437
lock (downloadDriverLock)
3538
{
36-
var version = EnvironmentConfiguration.GetVariable("webDriverVersion") ?? "Latest";
37-
new DriverManager().SetUpDriver(new ChromeConfig(), version: version);
39+
new DriverManager().SetUpDriver(new ChromeConfig(), VersionResolveStrategy.MatchingBrowser);
3840
}
3941

4042
return new ChromeApplication(services.GetRequiredService<ITimeoutConfiguration>());

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Aquality.Selenium.Core.Tests.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
<ItemGroup>
2828
<PackageReference Include="Appium.WebDriver" Version="4.2.1" />
29-
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.8" />
29+
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.9" />
3030
<PackageReference Include="nunit" Version="3.12.0" />
3131
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0">
3232
<PrivateAssets>all</PrivateAssets>

azure-pipelines.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ stages:
4444
displayName: Run tests
4545

4646
variables:
47-
webDriverVersion: '85.0.4183.83'
4847
isRemote: true
4948

5049
steps:
@@ -84,7 +83,7 @@ stages:
8483
- task: GitHubRelease@0
8584
displayName: 'Create tag on GitHub'
8685
inputs:
87-
gitHubConnection: 'GitHub'
86+
gitHubConnection: 'github.com_aqualityautomation'
8887
repositoryName: 'aquality-automation/aquality-selenium-core-dotnet'
8988
action: 'create'
9089
tag: 'v$(GitVersion.NuGetVersion)'

0 commit comments

Comments
 (0)