Release 4.0.8 (#41)

* Feature long request (#38)
* feat: add to_rfc1123_datetime helper function; create datetime_utils
* feat: add long_requests with check response
* refactor: simplify request handling
* refactor: use requests codes instead of numbers
* refactor: simplify _long_request_loop mechanism
* refactor: change `location` to capitalcase
* test: update server_connector tests
* test: add test for long_request
* test: fix travis config

* Fix full page screenshot in IE (#42)
* refactor: EyesWebdriverScreenshot class simplification
* test: add test_ie_viewport_screenshot
* fix: ie always return full page screenshot
   If FPS cut it to VP size

Author: eirenik0

.travis.yml

@@ -1,10 +1,11 @@
 language: python
+services:
+  - xvfb
 install:
     - pip install -U tox
 before_script:
     # Run GUI apps in headless mode
     - export DISPLAY=:99.0
-    - sh -e /etc/init.d/xvfb start
     - sleep 10 # give webdriver some time to start
     - export APPLITOOLS_BATCH_ID=`uuidgen -t`
 script:

eyes_common/applitools/common/config/configuration.py

@@ -9,7 +9,7 @@
 from applitools.common.geometry import RectangleSize
 from applitools.common.match import ImageMatchSettings, MatchLevel
 from applitools.common.server import FailureReports, SessionType
-from applitools.common.utils import argument_guard, general_utils
+from applitools.common.utils import UTC, argument_guard
 from applitools.common.utils.json_utils import JsonInclude
 
 __all__ = ("BatchInfo", "Configuration")
@@ -30,8 +30,7 @@ class BatchInfo(object):
         metadata={JsonInclude.THIS: True},
     )  # type: Optional[Text]
     started_at = attr.ib(
-        factory=lambda: datetime.now(general_utils.UTC),
-        metadata={JsonInclude.THIS: True},
+        factory=lambda: datetime.now(UTC), metadata={JsonInclude.THIS: True}
     )  # type: Union[datetime, Text]
     sequence_name = attr.ib(
         init=False,

eyes_common/applitools/common/utils/__init__.py

@@ -11,6 +11,11 @@
     urlsplit,
     urlunsplit,
 )
+from .datetime_utils import (  # type: ignore # noqa
+    UTC,
+    current_time_in_rfc1123,
+    to_rfc1123_datetime,
+)
 from .general_utils import cached_property  # noqa
 
 __all__ = compat.__all__ + ("image_utils", "argument_guard")  # noqa

eyes_common/applitools/common/utils/datetime_utils.py

@@ -0,0 +1,63 @@
+from datetime import datetime, timedelta, tzinfo
+from typing import Text
+
+__all__ = ("UTC", "to_rfc1123_datetime", "current_time_in_rfc1123")
+
+
+class _UtcTz(tzinfo):
+    """
+    A UTC timezone class which is tzinfo compliant.
+    """
+
+    _ZERO = timedelta(0)
+
+    def utcoffset(self, dt):
+        return _UtcTz._ZERO
+
+    def tzname(self, dt):
+        return "UTC"
+
+    def dst(self, dt):
+        return _UtcTz._ZERO
+
+
+UTC = _UtcTz()
+
+
+def to_rfc1123_datetime(dt):
+    # type: (datetime) -> Text
+    """Return a string representation of a date according to RFC 1123
+    (HTTP/1.1).
+
+    The supplied date must be in UTC.
+
+    """
+    weekday = ["Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"][dt.weekday()]
+    month = [
+        "Jan",
+        "Feb",
+        "Mar",
+        "Apr",
+        "May",
+        "Jun",
+        "Jul",
+        "Aug",
+        "Sep",
+        "Oct",
+        "Nov",
+        "Dec",
+    ][dt.month - 1]
+    return "%s, %02d %s %04d %02d:%02d:%02d GMT" % (
+        weekday,
+        dt.day,
+        month,
+        dt.year,
+        dt.hour,
+        dt.minute,
+        dt.second,
+    )
+
+
+def current_time_in_rfc1123():
+    # type: () -> Text
+    return to_rfc1123_datetime(datetime.now(UTC))

eyes_common/applitools/common/utils/general_utils.py

@@ -4,7 +4,6 @@
 import itertools
 import time
 import typing
-from datetime import timedelta, tzinfo
 
 from applitools.common import logger
 
@@ -21,27 +20,6 @@
     T = typing.TypeVar("T")
 
 
-class _UtcTz(tzinfo):
-    """
-    A UTC timezone class which is tzinfo compliant.
-    """
-
-    _ZERO = timedelta(0)
-
-    def utcoffset(self, dt):
-        return _UtcTz._ZERO
-
-    def tzname(self, dt):
-        return "UTC"
-
-    def dst(self, dt):
-        return _UtcTz._ZERO
-
-
-# Constant representing UTC
-UTC = _UtcTz()
-
-
 def use_default_if_none_factory(default_obj, obj):
     def default(attr_name):
         val = getattr(obj, attr_name)