Skip to content

Commit b37485e

Browse files
authored
Re-add NIO as a dependency of our library targets. (#1937)
Motivation: In #1935 I removed NIO as a dependency of a number of our library targets. This unfortunately led to some downstream breakage in modules that were (incorrectly) assuming they could import NIO without expressing a dependency on it in their Package.swift, e.g. swift-server/swift-aws-lambda-runtime#218. While a forums thread (https://forums.swift.org/t/semantic-versioning-should-removing-a-dependency-be-a-semver-major/51179) is ongoing to discuss the implications of this, we should re-add the dependency to undo the breakage against main. I've validated this locally: merely having the dependency is enough, we don't have to use it. Modifications: - Re-add NIO as a dependency to: - _NIOConcurrency - NIOFoundationCompat - NIOHTTP1 - NIOTLS - NIOWebSocket Result: Broken downstreams can build again.
1 parent 64285cb commit b37485e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Package.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ var targets: [PackageDescription.Target] = [
2929
"_NIODataStructures",
3030
"NIOEmbedded"]),
3131
.target(name: "_NIOConcurrency",
32-
dependencies: ["NIOCore"]),
33-
.target(name: "NIOFoundationCompat", dependencies: ["NIOCore"]),
32+
dependencies: ["NIO", "NIOCore"]),
33+
.target(name: "NIOFoundationCompat", dependencies: ["NIO", "NIOCore"]),
3434
.target(name: "CNIOAtomics", dependencies: []),
3535
.target(name: "CNIOSHA1", dependencies: []),
3636
.target(name: "CNIOLinux", dependencies: []),
@@ -39,7 +39,7 @@ var targets: [PackageDescription.Target] = [
3939
.target(name: "NIOConcurrencyHelpers",
4040
dependencies: ["CNIOAtomics"]),
4141
.target(name: "NIOHTTP1",
42-
dependencies: ["NIOCore", "NIOConcurrencyHelpers", "CNIOHTTPParser"]),
42+
dependencies: ["NIO", "NIOCore", "NIOConcurrencyHelpers", "CNIOHTTPParser"]),
4343
.target(name: "NIOEchoServer",
4444
dependencies: ["NIO", "NIOCore", "NIOConcurrencyHelpers"]),
4545
.target(name: "NIOEchoClient",
@@ -49,13 +49,13 @@ var targets: [PackageDescription.Target] = [
4949
.target(name: "NIOHTTP1Client",
5050
dependencies: ["NIO", "NIOCore", "NIOHTTP1", "NIOConcurrencyHelpers"]),
5151
.target(name: "CNIOHTTPParser"),
52-
.target(name: "NIOTLS", dependencies: ["NIOCore"]),
52+
.target(name: "NIOTLS", dependencies: ["NIO", "NIOCore"]),
5353
.target(name: "NIOChatServer",
5454
dependencies: ["NIO", "NIOCore", "NIOConcurrencyHelpers"]),
5555
.target(name: "NIOChatClient",
5656
dependencies: ["NIO", "NIOCore", "NIOConcurrencyHelpers"]),
5757
.target(name: "NIOWebSocket",
58-
dependencies: ["NIOCore", "NIOHTTP1", "CNIOSHA1"]),
58+
dependencies: ["NIO", "NIOCore", "NIOHTTP1", "CNIOSHA1"]),
5959
.target(name: "NIOWebSocketServer",
6060
dependencies: ["NIO", "NIOCore", "NIOHTTP1", "NIOWebSocket"]),
6161
.target(name: "NIOWebSocketClient",

0 commit comments

Comments
 (0)