Refactor error handling in decode_struct.go (#51)

kasugamirai · web-flow · commit 45411666b8b8 · 2024-04-19T08:19:42.000-07:00
This commit simplifies the error handling process within the decode_struct.go file. It removes an unnecessary nested conditional check around the existence of the 'Second' field, streamlining the code for better readability and efficiency.
diff --git a/pkl/decode_struct.go b/pkl/decode_struct.go
@@ -228,10 +228,8 @@ func (d *decoder) decodePair(typ reflect.Type) (*reflect.Value, error) {
 	}
 	secondField, exists := typ.FieldByName("Second")
 	if !exists {
-		if !exists {
-			return nil, &InternalError{
-				err: errors.New("unable to find field `Second` on pkl.Pair"),
-			}
+		return nil, &InternalError{
+			err: errors.New("unable to find field `Second` on pkl.Pair"),
 		}
 	}
 	second, err := d.Decode(secondField.Type)

Original file line number	Diff line number	Diff line change
`@@ -228,10 +228,8 @@ func (d decoder) decodePair(typ reflect.Type) (reflect.Value, error) {`
`228`	`228`	`}`
`229`	`229`	`secondField, exists := typ.FieldByName("Second")`
`230`	`230`	`if !exists {`
`231`		`- if !exists {`
`232`		`- return nil, &InternalError{`
`233`		- err: errors.New("unable to find field `Second` on pkl.Pair"),
`234`		`- }`
	`231`	`+ return nil, &InternalError{`
	`232`	+ err: errors.New("unable to find field `Second` on pkl.Pair"),
`235`	`233`	`}`
`236`	`234`	`}`
`237`	`235`	`second, err := d.Decode(secondField.Type)`