Skip to content

Commit 66f6be0

Browse files
committed
fix: fix empty value handling in caps
1 parent 236fc5e commit 66f6be0

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

lib/appium_lib_core/common/base/bridge.rb

-3
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,6 @@ def add_appium_prefix(capabilities)
121121
capabilities = capabilities.send(:capabilities) unless capabilities.is_a?(Hash)
122122

123123
capabilities.each do |name, value|
124-
next if value.nil?
125-
next if value.is_a?(String) && value.empty?
126-
127124
capability_name = name.to_s
128125
w3c_name = extension_prefix?(capability_name) ? name : "#{APPIUM_PREFIX}#{capability_name}"
129126

test/unit/common_test.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def test_add_appium_prefix_already_have_appium_prefix
139139
deviceName: 'iPhone Simulator',
140140
useNewWDA: true,
141141
some_capability1: 'some_capability1',
142-
someCapability2: 'someCapability2',
142+
someCapability2: '',
143143
'some_capability3' => 'string_shold_keep',
144144
'some_capability4' => {
145145
'nested_key1' => 1,
@@ -159,7 +159,7 @@ def test_add_appium_prefix_already_have_appium_prefix
159159
'deviceName' => 'iPhone Simulator',
160160
'useNewWDA' => true,
161161
'someCapability1' => 'some_capability1',
162-
'someCapability2' => 'someCapability2',
162+
'someCapability2' => '',
163163
'some_capability3' => 'string_shold_keep',
164164
'some_capability4' => { 'nested_key1' => 1, 'nestedKey2' => 2 }
165165
}
@@ -175,7 +175,7 @@ def test_add_appium_prefix_already_have_appium_prefix
175175
'appium:deviceName' => 'iPhone Simulator',
176176
'appium:useNewWDA' => true,
177177
'appium:some_capability1' => 'some_capability1',
178-
'appium:someCapability2' => 'someCapability2',
178+
'appium:someCapability2' => '',
179179
'appium:some_capability3' => 'string_shold_keep',
180180
'appium:some_capability4' => {
181181
'nested_key1' => 1,
@@ -192,7 +192,7 @@ def test_add_appium_prefix_already_have_appium_prefix
192192
'appium:deviceName' => 'iPhone Simulator',
193193
'appium:useNewWDA' => true,
194194
'appium:some_capability1' => 'some_capability1',
195-
'appium:someCapability2' => 'someCapability2',
195+
'appium:someCapability2' => '',
196196
'appium:some_capability3' => 'string_shold_keep',
197197
'appium:some_capability4' => {
198198
'nested_key1' => 1,

0 commit comments

Comments
 (0)