refactor: Update to work with Selenium 4 (with element factory) (#469)

* Add most fixes

* Get proect to build

* Use new platform setting  more consistantly

* Get WinAppTests kind of working

* Drop one off web elements
Add 'App' as a known capablity
Transition from AddAdditionalCapability to AddAdditionalOption

* Use Selenium 4 RC2 and remove extra using statements

* Cleanup mobile selectors and image compare test

* Fix mobile By bug

* Undo local test code

* Address PR comments

* Add back IdempotencyHeader

* PR related cleanup

* Update to latest Selenium RC

* Update PageObjects code to work with new Element and driver paradigm
Update tests to leverage configuration DeviceName and AddAdditionalAppiumOption

* Work with web element factory

* Update to work with upcoming RC4

* Move to official release as there will be no RC4

* Update copyright

* Put Newtonsoft back

* Use ternary operator

* Remove outdated using statements

Author: TroyWalshProf

src/Appium.Net/Appium.Net.csproj

@@ -8,7 +8,7 @@
     <Product>Appium-Dotnet-Driver</Product>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <Copyright>Copyright © 2020</Copyright>
+    <Copyright>Copyright © 2021</Copyright>
     <PackageProjectUrl>https://github.com/appium/appium-dotnet-driver</PackageProjectUrl>
     <RepositoryUrl>https://github.com/appium/appium-dotnet-driver</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
@@ -26,8 +26,8 @@
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'">
-    <DocumentationFile>Appium.Net.xml</DocumentationFile>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'">
+    <DocumentationFile>Appium.Net.xml</DocumentationFile>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net45|AnyCPU'">
     <DocumentationFile>Appium.Net.xml</DocumentationFile>
@@ -48,9 +48,8 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Newtonsoft.Json" Version="12.0.1" />
-    <PackageReference Include="Selenium.Support" Version="3.141.0" />
-    <PackageReference Include="Selenium.WebDriver" Version="3.141.0" />
+    <PackageReference Include="Selenium.Support" Version="4.0.0" />
+    <PackageReference Include="Selenium.WebDriver" Version="4.0.0" />
   </ItemGroup>
 
   <ItemGroup>

src/Appium.Net/Appium.Net.xml

@@ -16,7 +16,6 @@
 using OpenQA.Selenium.Appium.Enums;
 using OpenQA.Selenium.Appium.Interfaces;
 using OpenQA.Selenium.Appium.Service;
-using OpenQA.Selenium.Remote;
 using System;
 using System.Collections.Generic;
 using System.Drawing;
@@ -303,7 +302,7 @@ public IList<string> GetPerformanceDataTypes() =>
         public string EndTestCoverage(string intent, string path) =>
             AndroidCommandExecutionHelper.EndTestCoverage(this, intent, path);
 
-        protected override RemoteWebElementFactory CreateElementFactory() => new AndroidElementFactory(this);
+        protected override WebElementFactory CreateElementFactory() => new AndroidElementFactory(this);
 
         public void SetSetting(string setting, object value) =>
             AndroidCommandExecutionHelper.SetSetting(this, setting, value);

src/Appium.Net/Appium/Android/AndroidDriver.cs

@@ -14,7 +14,6 @@
 
 using OpenQA.Selenium.Appium.Enums;
 using OpenQA.Selenium.Appium.Interfaces;
-using OpenQA.Selenium.Remote;
 using System.Collections.Generic;
 
 namespace OpenQA.Selenium.Appium.Android
@@ -26,7 +25,7 @@ public class AndroidElement : AppiumWebElement, IFindByAndroidUIAutomator<Appium
         /// </summary>
         /// <param name="parent">Driver in use.</param>
         /// <param name="id">ID of the element.</param>
-        public AndroidElement(RemoteWebDriver parent, string id)
+        public AndroidElement(WebDriver parent, string id)
             : base(parent, id)
         {
         }

src/Appium.Net/Appium/Android/AndroidElement.cs

@@ -1,14 +1,13 @@
-using OpenQA.Selenium.Remote;
-
+
 namespace OpenQA.Selenium.Appium.Android
 {
     public class AndroidElementFactory : CachedElementFactory<AndroidElement>
     {
-        public AndroidElementFactory(RemoteWebDriver parentDriver) : base(parentDriver)
+        public AndroidElementFactory(WebDriver parentDriver) : base(parentDriver)
         {
         }
 
-        protected override AndroidElement CreateCachedElement(RemoteWebDriver parentDriver, string elementId)
+        protected override AndroidElement CreateCachedElement(WebDriver parentDriver, string elementId)
         {
             return new AndroidElement(parentDriver, elementId);
         }