chore: remove obsolete v4 functionality

Author: laolubenson

src/Appium.Net/Appium/AppiumDriver.cs

@@ -185,12 +185,6 @@ public void BackgroundApp() =>
             Execute(AppiumDriverCommand.BackgroundApp,
                 AppiumCommandExecutionHelper.PrepareArgument("seconds", -1));
 
-        [Obsolete(
-            "This method is obsolete & will be removed in the next major release. Call BackgroundApp(TimeSpan) instead.")]
-        public void BackgroundApp(int seconds) =>
-            Execute(AppiumDriverCommand.BackgroundApp,
-                AppiumCommandExecutionHelper.PrepareArgument("seconds", seconds));
-
         public void BackgroundApp(TimeSpan timeSpan) =>
             Execute(AppiumDriverCommand.BackgroundApp,
                 AppiumCommandExecutionHelper.PrepareArgument("seconds", timeSpan.TotalSeconds));

src/Appium.Net/Appium/Enums/AndroidMobileCapabilityType.cs

@@ -201,10 +201,6 @@ public sealed class AndroidMobileCapabilityType
          */
         public static readonly string RECREATE_CHROME_DRIVER_SESSIONS = "recreateChromeDriverSessions";
 
-        [System.Obsolete("Support for Selendroid is deprecated and will be removed in the next release")]
-        public static readonly string 
-            SELENDROID_PORT = "selendroidPort";
-
         /// <summary>
         /// In a web context, use native (adb) method for taking a screenshot, rather than proxying
         /// to ChromeDriver, default false.

src/Appium.Net/Appium/Enums/AutomationName.cs

@@ -19,8 +19,6 @@ namespace OpenQA.Selenium.Appium.Enums
     public sealed class AutomationName
     {
         public static readonly string Appium = "Appium";
-        [Obsolete("Support for Selendroid is deprecated and will be removed in the next release")]
-        public static readonly string Selendroid = "Selendroid";
         public static readonly string iOSXcuiTest = "XCuiTest";
         public static readonly string AndroidUIAutomator2 = "UIAutomator2";
         public static readonly string AndroidEspresso = "Espresso";

src/Appium.Net/Appium/Interfaces/IInteractsWithApps.cs

@@ -47,12 +47,6 @@ public interface IInteractsWithApps : IExecuteMethod
         /// </summary>
         void BackgroundApp();
 
-        /// <summary>
-        /// Backgrounds the current app for the given number of seconds or deactivates app completely if negative number is given. 
-        /// </summary>
-        /// <param name="seconds">an integer number containing the number of seconds.</param>
-        void BackgroundApp(int seconds);
-
         /// <summary>
         /// Backgrounds the current app for the given number of seconds or deactivates app completely if negative number is given. 
         /// </summary>

src/Appium.Net/Appium/Service/Options/AndroidOptionList.cs

@@ -34,17 +34,6 @@ public sealed class AndroidOptionList : BaseOptionList
         public static KeyValuePair<string, string> BootstrapPort(string value) =>
             GetKeyValuePairUsingDefaultValue("--bootstrap-port", value, "4724");
 
-
-        ///<summary>
-        /// Local port used for communication with Selendroid<br/>
-        /// Sample:<br/>
-        /// --selendroid-port 8080
-        ///</summary>
-        ///
-        [Obsolete("Support for Selendroid is deprecated and will be removed in the next release")]
-        public static KeyValuePair<string, string> SelendroidPort(string value) =>
-            GetKeyValuePairUsingDefaultValue("--selendroid-port", value, "8080");
-
         ///<summary>
         /// If set, prevents Appium from killing the adb server
         /// instance<br/>

test/integration/Android/Device/AppTests.cs

@@ -76,14 +76,14 @@ public void CanBackgroundApp()
         public void CanBackgroundAppForSeconds()
         {
             Assert.DoesNotThrow(
-                () => _driver.BackgroundApp(5));
+                () => _driver.BackgroundApp(TimeSpan.FromSeconds(5)));
         }
 
         [Test]
         public void CanBackgroundAppToDeactivationUsingNegativeSecond()
         {
             Assert.DoesNotThrow(
-                () => _driver.BackgroundApp(-1));
+                () => _driver.BackgroundApp(-TimeSpan.FromSeconds(-1)));
         }
 
         #endregion

test/integration/IOS/Device/AppTests.cs

@@ -89,7 +89,7 @@ public void CanBackgroundApp()
         public void CanBackgroundAppForSeconds()
         {
             Assert.DoesNotThrow(
-                () => _driver.BackgroundApp(5));
+                () => _driver.BackgroundApp(TimeSpan.FromSeconds(5)));
         }
 
         [Test]
@@ -103,7 +103,7 @@ public void CanBackgroundAppForTimeSpan()
         public void CanBackgroundAppToDeactivationUsingNegativeSecond()
         {
             Assert.DoesNotThrow(
-                () => _driver.BackgroundApp(-1));
+                () => _driver.BackgroundApp(TimeSpan.FromSeconds(-1)));
             Assert.DoesNotThrow(() => _driver.FindElement(MobileBy.AccessibilityId(IosDockElement)));
         }