chore: Remove Rotate endpoint (#756)

* test: Add RotationTest

* chore: Remove casting

* chore: Remove appium/device/rotate endpoint

* chore: Remove Rotate methods from AppiumDriver and AppiumElement

Author: Dor-bl

src/Appium.Net/Appium/AppiumCommand.cs

@@ -88,8 +88,6 @@ public class AppiumCommand
                 "/session/{sessionId}/appium/device/press_keycode"),
             new AppiumCommand(HttpCommandInfo.PostCommand, AppiumDriverCommand.LongPressKeyCode,
                 "/session/{sessionId}/appium/device/long_press_keycode"),
-            new AppiumCommand(HttpCommandInfo.PostCommand, AppiumDriverCommand.Rotate,
-                "/session/{sessionId}/appium/device/rotate"),
             new AppiumCommand(HttpCommandInfo.GetCommand, AppiumDriverCommand.GetCurrentActivity,
                 "/session/{sessionId}/appium/device/current_activity"),
             new AppiumCommand(HttpCommandInfo.GetCommand, AppiumDriverCommand.GetCurrentPackage,

src/Appium.Net/Appium/AppiumDriver.cs

@@ -135,33 +135,6 @@ Response IExecuteMethod.Execute(string commandName, Dictionary<string, object> p
 
         #region MJsonMethod Members
 
-        /// <summary>
-        /// Rotates the device.
-        /// </summary>
-        /// <param name="opts">
-        /// Rotations options like the following:
-        /// <example>
-        /// new Dictionary&lt;string, int&gt; {
-        ///     {"x", 114},
-        ///     {"y", 198},
-        ///     {"duration", 5},
-        ///     {"radius", 3},
-        ///     {"rotation", 220},
-        ///     {"touchCount", 2}
-        /// }
-        /// </example>
-        /// </param>
-        public void Rotate(Dictionary<string, int> opts)
-        {
-            Dictionary<string, object> parameters = new Dictionary<string, object>();
-            foreach (KeyValuePair<string, int> opt in opts)
-            {
-                parameters.Add(opt.Key, opt.Value);
-            }
-
-            Execute(AppiumDriverCommand.Rotate, parameters);
-        }
-
         public void InstallApp(string appPath) =>
             Execute(AppiumDriverCommand.InstallApp, AppiumCommandExecutionHelper.PrepareArgument("appPath", appPath));
 

src/Appium.Net/Appium/AppiumDriverCommand.cs

@@ -78,11 +78,6 @@ public class AppiumDriverCommand
         /// </summary>
         public const string LongPressKeyCode = "longPressKeyCode";
 
-        /// <summary>
-        /// Rotate Command.
-        /// </summary>
-        public const string Rotate = "rotate";
-
         /// <summary>
         /// Get CurrentActivity Command.
         /// </summary>

src/Appium.Net/Appium/AppiumElement.cs

@@ -178,37 +178,6 @@ protected virtual object CacheValue(string key, Func<object> getter)
 
         #endregion
 
-        #region MJSonMethods
-
-        /// <summary>
-        /// Rotates the device.
-        /// </summary>
-        /// <param name="opts">
-        /// Rotations options like the following:
-        /// <example>
-        /// new Dictionary&lt;string, int&gt; {
-        ///     {"x", 114},
-        ///     {"y", 198},
-        ///     {"duration", 5},
-        ///     {"radius", 3},
-        ///     {"rotation", 220},
-        ///     {"touchCount", 2}
-        /// }
-        /// </example>
-        /// </param>
-        public void Rotate(Dictionary<string, int> opts)
-        {
-            Dictionary<string, object> parameters = new Dictionary<string, object>();
-            foreach (KeyValuePair<string, int> opt in opts)
-            {
-                parameters.Add(opt.Key, opt.Value);
-            }
-            parameters.Add("element", Id);
-            Execute(AppiumDriverCommand.Rotate, parameters);
-        }
-
-        #endregion
-
         [Obsolete("The SetImmediateValue method is deprecated and will be removed in future versions. Please use 'SendKeys' instead.")]
         public void SetImmediateValue(string value) => Execute(AppiumDriverCommand.SetValue,
             new Dictionary<string, object>() { ["id"] = Id, ["value"] = value });

test/integration/Android/OrientationTest.cs

@@ -1,14 +1,15 @@
 using Appium.Net.Integration.Tests.helpers;
 using NUnit.Framework;
 using OpenQA.Selenium;
+using OpenQA.Selenium.Appium;
 using OpenQA.Selenium.Appium.Android;
 
 namespace Appium.Net.Integration.Tests.Android
 {
     [TestFixture]
     class OrientationTest
     {
-        private IWebDriver _driver;
+        private AppiumDriver _driver;
 
         [OneTimeSetUp]
         public void BeforeAll()
@@ -34,9 +35,16 @@ public void AfterAll()
         [Test]
         public void DeviceOrientationTest()
         {
-            var rotatable = ((IRotatable) _driver);
+            IRotatable rotatable = _driver;
             rotatable.Orientation = ScreenOrientation.Portrait;
             Assert.That(rotatable.Orientation, Is.EqualTo(ScreenOrientation.Portrait));
         }
+
+        [Test]
+        public void RotationTest()
+        {
+            _driver.Orientation = ScreenOrientation.Landscape;
+            Assert.That(_driver.Orientation, Is.EqualTo(ScreenOrientation.Landscape));
+        }
     }
 }