Skip to content

Commit bc23280

Browse files
authored
chore: fixes and code improvements on Windows MultiSelectControlTest (#739)
1 parent e2fd45e commit bc23280

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/integration/Windows/MultiSelectControlTest.cs

+9-9
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public void OneTimeTearDown()
8080
alarmEntry.Click();
8181
AlarmClockSession.FindElement(MobileBy.AccessibilityId("DeleteButton")).Click();
8282
}
83-
83+
AlarmClockSession.Quit();
8484
AlarmClockSession.Dispose();
8585
AlarmClockSession = null;
8686
DesktopSession.Dispose();
@@ -93,27 +93,27 @@ public void FullMultiSelectScenario()
9393
// Read the current local time
9494
SwitchToWorldClockTab();
9595
var localTimeText = ReadLocalTime();
96-
Assert.That(localTimeText.Length > 0);
96+
Assert.That(localTimeText, Is.Not.Empty);
9797

9898
// Add an alarm at 1 minute after local time
9999
SwitchToAlarmTab();
100100
AddAlarm(localTimeText);
101101
Thread.Sleep(300);
102102
var alarmEntries = AlarmClockSession.FindElements(MobileBy.Name("Windows Application Driver Test Alarm"));
103-
Assert.That(alarmEntries.Count > 0);
103+
Assert.That(alarmEntries, Is.Not.Empty);
104104
}
105105

106-
public static void SwitchToAlarmTab()
106+
private static void SwitchToAlarmTab()
107107
{
108108
AlarmClockSession.FindElement(MobileBy.AccessibilityId("AlarmButton")).Click();
109109
}
110110

111-
public void SwitchToWorldClockTab()
111+
private static void SwitchToWorldClockTab()
112112
{
113113
AlarmClockSession.FindElement(MobileBy.AccessibilityId("ClockButton")).Click();
114114
}
115115

116-
public string ReadLocalTime()
116+
private static string ReadLocalTime()
117117
{
118118
var localTimeText = "";
119119
AppiumElement worldClockPivotItem =
@@ -126,7 +126,7 @@ public string ReadLocalTime()
126126
foreach (var timeString in timeStrings)
127127
{
128128
// Get the time. E.g. "11:32 AM" from "Local time, Monday, February 22, 2016, 11:32 AM, "
129-
if (timeString.Contains(":"))
129+
if (timeString.Contains(':'))
130130
{
131131
localTimeText = new string(timeString.Trim().Where(c => c < 128).ToArray()); // Remove 8206 character, see https://stackoverflow.com/questions/18298208/strange-error-when-parsing-string-to-date
132132
break;
@@ -137,7 +137,7 @@ public string ReadLocalTime()
137137
return localTimeText;
138138
}
139139

140-
public void AddAlarm(string timeText)
140+
private static void AddAlarm(string timeText)
141141
{
142142
if (timeText.Length > 0)
143143
{
@@ -171,7 +171,7 @@ public void AddAlarm(string timeText)
171171
}
172172
}
173173

174-
public void DismissNotification()
174+
private static void DismissNotification()
175175
{
176176
try
177177
{

0 commit comments

Comments
 (0)