Skip to content

Commit a048964

Browse files
authored
fix: device system time null exception (#448)
closes #440
1 parent e75c1eb commit a048964

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/Appium.Net/Appium.Net.csproj

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
<TargetFrameworks>netstandard2.0;net45</TargetFrameworks>
55
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
66
<RootNamespace>OpenQA.Selenium</RootNamespace>
7-
<AssemblyVersion>4.2.0</AssemblyVersion>
8-
<Version>4.2.0</Version>
97
<Company>Appium Commiters</Company>
108
<Product>Appium-Dotnet-Driver</Product>
119
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
12-
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
10+
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
1311
<Copyright>Copyright © 2020</Copyright>
1412
<PackageProjectUrl>https://github.com/appium/appium-dotnet-driver</PackageProjectUrl>
1513
<RepositoryUrl>https://github.com/appium/appium-dotnet-driver</RepositoryUrl>
@@ -26,7 +24,6 @@
2624

2725
<PropertyGroup>
2826
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
29-
<FileVersion>4.2.0</FileVersion>
3027
</PropertyGroup>
3128

3229
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'">

src/Appium.Net/Appium/AppiumDriverCommand.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ public class AppiumDriverCommand
201201
/// <summary>
202202
/// Get the time on the device
203203
/// </summary>
204-
public const string SystemTime = "system_time";
204+
public const string SystemTime = "getDeviceTime";
205205

206206
/// <summary>
207207
/// Get Display Density

test/integration/Android/EmulatorDeviceTime.cs

+8-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using NUnit.Framework;
44
using OpenQA.Selenium.Appium;
55
using OpenQA.Selenium.Appium.Android;
6+
using static System.String;
67

78
namespace Appium.Net.Integration.Tests.Android
89
{
@@ -35,8 +36,13 @@ public void AfterEach()
3536
public void DeviceTimeTest()
3637
{
3738
var time = _driver.DeviceTime;
38-
Console.WriteLine(time);
39-
Assert.AreEqual(true, time.Length == 28);
39+
Assert.Multiple(() =>
40+
{
41+
Assert.NotNull(time);
42+
Assert.AreNotEqual(Empty, time);
43+
Console.WriteLine(time);
44+
Assert.NotNull(DateTime.Parse(time));
45+
});
4046
}
4147
}
4248
}

0 commit comments

Comments
 (0)