Merge pull request #60 from Jonahss/master

added GetSettings() and IgnoreUnimportantViews()

Author: Astro03

appium-dotnet-driver/Appium/AppiumDriver.cs

@@ -28,6 +28,7 @@
 using System.Reflection;
 using OpenQA.Selenium.Appium.src.Appium.Interfaces;
 using System.Diagnostics.Contracts;
+using Newtonsoft.Json;
 
 namespace OpenQA.Selenium.Appium
 {
@@ -741,6 +742,40 @@ public void PerformTouchAction(TouchAction touchAction)
 
         #endregion Multi Actions
 
+		#region Settings
+
+		/// <summary>
+		/// Get appium settings currently set for the session
+		/// See: https://github.com/appium/appium/blob/master/docs/en/advanced-concepts/settings.md
+		/// </summary>
+		public Dictionary<String, Object> GetSettings()
+		{
+			var commandResponse = this.Execute(AppiumDriverCommand.GetSettings, null);
+			return JsonConvert.DeserializeObject<Dictionary<String, Object>>((String) commandResponse.Value);
+		}
+
+		/// <summary>
+		/// Set "ignoreUnimportantViews" setting.
+		/// See: https://github.com/appium/appium/blob/master/docs/en/advanced-concepts/settings.md
+		/// </summary>
+		public void IgnoreUnimportantViews(bool value)
+		{
+			this.UpdateSetting ("ignoreUnimportantViews", value);
+		}
+
+		/// <summary>
+		/// Update an appium Setting, on the session
+		/// </summary>
+		private void UpdateSetting(String setting, Object value)
+		{
+			var parameters = new Dictionary<string, object>();
+			var settings = new Dictionary<string, object>();
+			settings.Add(setting, value);
+			parameters.Add("settings", settings);
+			this.Execute(AppiumDriverCommand.UpdateSettings, parameters);
+		}
+		#endregion Settings
+
         #endregion Public Methods
 
         #region Internal Methods
@@ -862,7 +897,9 @@ private static void _AddAppiumCommands()
                 new _Commands(CommandInfo.PostCommand, AppiumDriverCommand.HideKeyboard, "/session/{sessionId}/appium/device/hide_keyboard"),
                 new _Commands(CommandInfo.PostCommand, AppiumDriverCommand.OpenNotifications, "/session/{sessionId}/appium/device/open_notifications"),
                 new _Commands(CommandInfo.PostCommand, AppiumDriverCommand.StartActivity, "/session/{sessionId}/appium/device/start_activity"),
-                #endregion Appium Commands
+				new _Commands(CommandInfo.GetCommand,  AppiumDriverCommand.GetSettings, "/session/{sessionId}/appium/settings"),
+				new _Commands(CommandInfo.PostCommand, AppiumDriverCommand.UpdateSettings, "/session/{sessionId}/appium/settings"),
+				#endregion Appium Commands
                 #region Touch Commands
                 new _Commands(CommandInfo.PostCommand, AppiumDriverCommand.MultiActionV2Perform, "/session/{sessionId}/touch/multi/perform"),
                 new _Commands(CommandInfo.PostCommand, AppiumDriverCommand.TouchActionV2Perform, "/session/{sessionId}/touch/perform"),

appium-dotnet-driver/Appium/AppiumDriverCommand.cs

@@ -225,6 +225,16 @@ public class AppiumDriverCommand
         /// </summary>
         public const string GetScreenshot = "screenshot";
 
+		/// <summary>
+		/// Represents the GetSettings Command
+		/// </summary>
+		public const string GetSettings = "getSettings";
+
+		/// <summary>
+		/// Represents the UpdateSettings Command
+		/// </summary>
+		public const string UpdateSettings = "updateSettings";
+
         #endregion JSON Wire Protocol
     }
 }

test/specs/MJsonMethodTest.cs

@@ -246,6 +246,24 @@ public void HideKeyboardTestCase ()
 			}
 		}
 
+		[Test]
+		public void SettingsTestCase ()
+		{
+			{
+				var data = "{\"setting\": true}";
+				Dictionary<String, Object> simpleDict = new Dictionary<string, object> ();
+				simpleDict.Add ("setting", true);
+				server.respondTo ("GET", "/appium/settings", data);
+				var result = driver.GetSettings ();
+				Assert.AreEqual (result, simpleDict);
+			}
+			{
+				RequestProcessor re = server.respondTo ("POST", "/appium/settings", null);
+				driver.IgnoreUnimportantViews (true);
+				Assert.AreEqual (re.inputData, "{\"settings\":{\"ignoreUnimportantViews\":true}}");
+			}
+		}
+
 	}
 }