Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find an AdmZip alternative #38

Closed
scottdixon-zz opened this issue Sep 11, 2015 · 1 comment
Closed

Find an AdmZip alternative #38

scottdixon-zz opened this issue Sep 11, 2015 · 1 comment

Comments

@scottdixon-zz
Copy link

Find an AdmZip alternative to zip files in the commands.pullFolder method.

commands.pullFolder = async function (remotePath) {
  let localFolder = temp.path({prefix: 'appium'});
  await this.adb.pull(remotePath, localFolder);
  // TODO: find a better alternative to the AdmZip module
  let zip = new AdmZip();
  zip.addLocalFolder(localFolder);
  return new Promise((resolve, reject) => {
    zip.toBuffer((buffer) => {
      logger.debug("Converting in-memory zip file to base64 encoded string");
      resolve(buffer.toString('base64'));
    }, (err) => {
      reject(err);
    });
  });
};
@rkavalap
Copy link

rkavalap commented Dec 6, 2016

Issue moved to appium/appium #7397 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants