noReset/fullReset ignored when using appActivity/appPackage

[tiagoshibata]

The problem

When the appActivity and appPackage capabilities are used instead of app, noReset and fullReset are ignored. This is due to the reset logic being contained in function installApkRemotely, which is not called when not using the app capability.

Environment

• Git revision that exhibits the issue: 53fa62e
• Desktop OS/version used to run Appium: Linux
• Node.js version: v6.2.1
• Mobile platform/version under test: Android
• Real device or emulator/simulator: Real device
• Appium CLI or Appium.app|exe: CLI

Link to Appium logs

Gist log

Code To Reproduce Issue

In the following example, the app data remains on the phone instead of being erased.

#!/usr/bin/env python3
import appium
import time

capabilities = {
    'appActivity': "com.ansca.corona.CoronaActivity",
    'appPackage': "br.com.tapps.vloggergoviral",
    'deviceName': "Android",
    'platformName': "Android",
    'noReset': False
}

webdriver = appium.webdriver.Remote("http://localhost:4723/wd/hub", capabilities)
time.sleep(15)
webdriver.quit()

Expected behavior: app is reset when noReset = false and an error is raised then fullReset = true and no app capability is provided.

I will create a pull request for this soon.