Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setGeoLocation returns random info #144

Closed
imurchie opened this issue May 13, 2016 · 2 comments
Closed

setGeoLocation returns random info #144

imurchie opened this issue May 13, 2016 · 2 comments
Assignees
@mykola-mokhnach

Comments

@imurchie
Copy link
Contributor

The spec says we should be returning the location. If it is not possible in our new scheme to find the actual location, we should, if there is no error in setting, return the location that was requested.
@imurchie
Copy link
Contributor Author

The problem is here: https://github.com/appium/appium-android-driver/blob/master/lib/commands/network.js#L82

Rather than returning the value form the adb call, we should be awaiting that and returning other information.

@rkavalap
Copy link

rkavalap commented Dec 6, 2016

Issue moved to appium/appium #7400 via ZenHub

@rkavalap rkavalap closed this as completed Dec 6, 2016
@rkavalap rkavalap mentioned this issue Dec 6, 2016
Closed
@mykola-mokhnach mykola-mokhnach self-assigned this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mykola-mokhnach mykola-mokhnach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rkavalap @imurchie @mykola-mokhnach