Skip to content

implement an Iterator for parse errors #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrlna opened this issue Oct 4, 2021 · 4 comments
Closed

implement an Iterator for parse errors #86

lrlna opened this issue Oct 4, 2021 · 4 comments
Assignees

Comments

@lrlna
Copy link
Member

lrlna commented Oct 4, 2021

No description provided.

@jregistr
Copy link
Contributor

jregistr commented Oct 15, 2021

Hi there. This looks like a nice small issue 😄 . To confirm, is this referring to the Parser struct errors Vec?

pub struct Parser {
    ...
    errors: Vec<crate::Error>,
}

@lrlna
Copy link
Member Author

lrlna commented Oct 20, 2021

hi @jregistr ! Sorry this issue had no description since I totally just made it for myself to track 😅. It is indeed referring to the Parser's error vec!

That being said, while we prep for the 0.1.0 release, I won't be able to accept something like this as an external contribution. This is mainly because I have to do a bunch of changes to some of the internals and it will difficult to get this to work on a rapidly changing codebase. Once we are set up and running with a release schedule, I can start thinking about how best to handle contributions and onboard folks. Hope that's ok!

@jregistr
Copy link
Contributor

No problem 🙂 . I unfortunately looked into this prior to reading the comments in the Contributing docs.

@abernix abernix added 2021-11 and removed 2021-10 labels Nov 2, 2021
@lrlna
Copy link
Member Author

lrlna commented Jan 20, 2022

this was done in #120, and we completely forgot to link it to this original issue.

@lrlna lrlna closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants