-
Notifications
You must be signed in to change notification settings - Fork 682
Open
Labels
⚠️ Breaking ChangeTo be done in next major versionTo be done in next major version
Description
This is a list of changes that we don't want to forget about. They are likely to be backwards-incompatible so most of these will need to wait for a future major release. This list is mostly a braindump and is missing a lot of context. This is not about new features but rather a list of small cleanups to do.
Continued from #4171
If you see anything that doesn't make any sense, it's probably because it doesn't. Feel free to comment and we'll dive into it.
Potential Breaking Changes/cleanups
- Rename
HttpInterceptor.dispose()
toHttpInterceptor.close()
- Rename
Foo.type
toFoo.__type
to avoid nameclashes (or just leave it like this because we can detect the case. See 'type' is a reserved enum value name #4293) - Rewrite the buffered adapters to not use JsonReader anymore
- Cleanup the
JsonReader
API and distinguish between the buffer/non buffered case. - Generate the customScalarAdapters?
- Make the field merging validation more strict (see Add a flag to disable fieldsCanMerge validation on disjoint types #4342 (review))
- Use scalar instead of customScalar API cleanup: use "scalar" instead of "custom scalar" #3815
- Refactor
shapes()
- Move httpInfo and others outside of executionContext
- Improve the Java ergonomics of
HttpKt
- (To be considered): pass the variant name to the lambda for
createAllAndroidVariantServices
(see this comment) (or deprecate the function?) - Rename
WsProtocol.Factory
toWsProtocol.Builder
- Remove circular dependencies between Gradle projects
- extract HttpEngine and WebSocketEngine to a common module
- Replace ApolloClient.Builder.httpCache with HttpNetworkTransport.httpCache (requires using ExecutionContext from HttpEngine)
- Move NormalizedCacheFactory from expect/actual to an interface
- Remove IdlingResource. See this comment from OkHttp for instance, and this article about how to avoid them with Compose.
- Remove Gradle defaultService
- Enforce opt-in the
kotlin_labs
linking - check all TODO v5
- Do not add
@defer
automatically to the schema
Metadata
Metadata
Assignees
Labels
⚠️ Breaking ChangeTo be done in next major versionTo be done in next major version