Skip to content

Commit d1e8271

Browse files
authored
Fixes incorrectly decoded querystring for GET requests (#122)
* Fixes incorrectly decoded querystring for GET requsts * Changeset * Upgrade to minor version
1 parent a5f2461 commit d1e8271

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.changeset/warm-horses-push.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@as-integrations/aws-lambda': minor
3+
---
4+
5+
Fixes missing `decodeURIComponent` during GET request parsing of querystring for ALB and V1 event

src/request-handlers/ALBEventRequestHandler.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ export const createALBEventRequestHandler = <
3737
for (const [key, value] of Object.entries(
3838
event.queryStringParameters ?? {},
3939
)) {
40-
params.append(key, value ?? '');
40+
params.append(key, decodeURIComponent(value ?? ''));
4141
}
4242
for (const [key, value] of Object.entries(
4343
event.multiValueQueryStringParameters ?? {},
4444
)) {
4545
for (const v of value ?? []) {
46-
params.append(key, v);
46+
params.append(key, decodeURIComponent(v));
4747
}
4848
}
4949
return params.toString();

src/request-handlers/APIGatewayProxyEventRequestHandler.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const createAPIGatewayProxyEventRequestHandler = <
3838
event.multiValueQueryStringParameters ?? {},
3939
)) {
4040
for (const v of value ?? []) {
41-
params.append(key, v);
41+
params.append(key, decodeURIComponent(v));
4242
}
4343
}
4444
return params.toString();

0 commit comments

Comments
 (0)